Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gherkin-go to last version #202

Closed
inluxc opened this issue Dec 17, 2019 · 8 comments
Closed

Update Gherkin-go to last version #202

inluxc opened this issue Dec 17, 2019 · 8 comments
Assignees
Milestone

Comments

@inluxc
Copy link

inluxc commented Dec 17, 2019

We need to update the gherkin-go library to the latest version v.9.0.0, so we can fix problems like #124, to add attachments to the step error messages.

@l3pp4rd
Copy link
Member

l3pp4rd commented Dec 20, 2019

Hi, integrating later gherkin version, would require protobuf dependency, in my opinion test related libraries should not have chains of dependencies.

Though, since I do not have time now to properly maintain this library, it may be considerable to move it to cucumber organization if there would be maintainers. they probably would instantly migrate it to recent gherkin version.

@l3pp4rd
Copy link
Member

l3pp4rd commented Dec 20, 2019

will speak to the cucumber organization about migration of the repository and handing over the main maintenance.

@lonnblad
Copy link
Member

@l3pp4rd hey, did you get a chance to talk to them?
if you would want to, I can help you to maintain the repo otherwise

@l3pp4rd
Copy link
Member

l3pp4rd commented Jan 31, 2020

yes I've sent the email a month ago, but got no response yet, so probably it got lost or forgotten, will resend it again, and probably try other channels

@l3pp4rd
Copy link
Member

l3pp4rd commented Jan 31, 2020

got the response fast today, will be moving it to cucumber organization, it should receive more proper maintenance!

@lonnblad
Copy link
Member

lonnblad commented Feb 4, 2020

I was planning to take a stab at this and see if I can sort it out

@l3pp4rd
Copy link
Member

l3pp4rd commented Feb 5, 2020

may not be that simple, since there were changes in gherkin Rule added, the pretty formatter will change. though, would be best to find ways how to do it incrementally. maybe just supporting new lib and current gherkin features present. then next step after library is migrated, implement the new features, such as Rule keyword. Also later, based on other cucumber implementations, it seems to be better to compile gherkin Scenario outline to separate scenario list given all the examples in table. though, you could have a look at cucumber-js. but first just library migration, do not step into large refactorings because it will slow you down, do it incrementally.

@lonnblad
Copy link
Member

lonnblad commented Feb 5, 2020

yep, agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants