New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter using keyCode and not name #32

Open

artfuldev opened this issue Jul 27, 2016 · 0 comments

Member

artfuldev commented Jul 27, 2016

We might miss alias names if we check the current way:

if(typeof key === 'string')
  return keyUp$.filter(ev => ev.displayKey === key);

We are better off using

if(typeof key === 'string')
  return keyUp$.filter(ev => ev.keyCode === keycode.codes[key]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment