-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the library pulls in automatically android.permission.FOREGROUND_SERVICE_MEDIA_PROJECTION permission #56
Comments
We have the exact same issue :) |
We had the same issue, I did not add this permission into AndroidManifest file but we published it to Google Play Store and today we are facing an issue on Prod as;
Even though we did tests in Staging and didn't face any issue, this happened on prod and I am assuming we must to add this permission in Manifest file! And Daily developers should add this information in documents! |
Hi, thank you for reporting this. As @chr4ss12 mentioned in the issue, the problem lies within You shouldn't need to add this dependency unless it's actually being used, such as when you intend to enable screen sharing in your app. We already have a task in our backlog to address this issue. I'll let you know as soon as we release a version with the fix. |
Hello @filipi87, So if we should not add this into Manifest while then why does DailyPlayground App have it? |
Hi @mkilincaslan, You should only need to add this if you intend to support screen sharing. In our playground example, we do support screen sharing, so we include this permission. And that is correct. However, if you don't plan to support screen sharing in your app, you shouldn't need to add this permission. |
While we don't release a version with the fix, and if you don't need to support screen share, you can do as suggested in the first comment of this issue, that is to change your
|
I added the library to my project, and I did NOT add
"android.permission.FOREGROUND_SERVICE_MEDIA_PROJECTION" permission, however when I went to submit my app to Play Store, it required me to explain for what I am using this permission for.
Upon investigating a bit, I think the culprit is file node_modules/@daily-co/react-native-webrtc/android/src/main/AndroidManifest.xml
that has
added to it.
I do not exactly understand how the playstore permission detection or Android manifests work, but regardless I've had to change my own Androidmanifest to get rid of this:
The text was updated successfully, but these errors were encountered: