Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rework/add spinner so that it can be used in smaller areas (WEB-124) #127

Open
dgarcia-appdev opened this issue Feb 9, 2025 · 2 comments
Labels
chore basic task

Comments

@dgarcia-appdev
Copy link
Contributor

Task

Rework the Spinner component so that sections of a page can have a spinner. To be more specific the area that needs this is the "community" page when it is loading the team and speakers.

Steps to contribute. NEVER COMMIT TO MAIN. NEVER COMMIT TO MAIN. It should always be on your own branch and that branch name should match the issue. Ensure that you are addressing the correct issue. Each issue will be listed as something like a chore, fix, bug, etc. Your commit message MUST start with one of these tags that correspond with your issue. Followed by your commit message and your commit message must end with the branch name, for example (WEB-1)

An example commit message would look like this: chore: create contributing guidelines (WEB-8)

Commit messages should not be written in an action or present tense. It also should not mention tasks unrelated to the issue "Creating Contributing Guidelines and will work on next task" is not what we would want to see as a commit message.

After a pull request is approved, the branch should be deleted once merged.

@dgarcia-appdev dgarcia-appdev added the chore basic task label Feb 9, 2025
@missatrox44
Copy link

i can work on this!!

@missatrox44
Copy link

@dgarcia-appdev seeking some clarification. do you mean the spinner should only appear in the section that loads the team and the past speakers? In other words, should there be two instances of this spinner on the same page? As far as styles, do we want a background or just have the spinner on top of whatever section is loading? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore basic task
Projects
None yet
Development

No branches or pull requests

2 participants