dt_dev_pixelpipe_change() should only be called if there is a change #18233
Conversation
This avoids unnecessary and costly history locking and calls to dt_dev_pixelpipe_get_dimensions() if pipe->changed == DT_DEV_PIPE_UNCHANGED
jenshannoschwalm
added
bugfix
|
I'm afraid I haven't been able to reproduce it after the initial report. I can maybe try again tomorrow. |
|
Still doing it. I tried the slight zoom and pan suggestion and that didn't stop it. Had to go out to lighttable. EDIT: The modules I applied were color calibration, tone equalizer, and lens correction. |
|
@wpferguson could you do a log with |
|
This time it happened when I loaded an image. A style is applied, then a color calibration preset and lens correction. The log time the image was loaded is 244.2206. There were 5 images processed before that, so you can get a feel for what I'm doing. |
|
A new issue with the patch. Sometimes when I try and advance to the next image, the current image resets and loses all of it's edits. |
|
This PR introduced a couple of other problems and didn't make any improvement to the existing problem. EDIT: After going back to master, without this PR, I reproduced the errors that I though were caused by the PR. So, it seems that while the PR didn't fix anything, it didn't break anything worse than it already was. |
This avoids unnecessary and costly history locking and calls to dt_dev_pixelpipe_get_dimensions() if pipe->changed == DT_DEV_PIPE_UNCHANGED
Fixes #18232
Fixes #18014
@kofa73 @wpferguson would you both check please ?