{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":19352450,"defaultBranch":"develop","name":"dash","ownerLogin":"dashpay","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2014-05-01T17:45:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/11511719?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1723033416.0","currentOid":""},"activityList":{"items":[{"before":"d754799580d2914a0dd6388c90100d14feec0428","after":"89a7c60aecff893e9e422ac006621eef89ae4e62","ref":"refs/heads/develop","pushedAt":"2024-09-18T16:27:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6277: chore: add builder key for kittywhiskers\n\n315fcea83493266449a96739c7f028cdff00cc75 chore: add builder key for kittywhiskers (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n Key ID `30CD 0C06 5E5C 4AAD`. Same key registered with Keybase ([source](https://keybase.io/kittywhiskers/pgp_keys.asc?fingerprint=969187a8e74fe40a8a48067430cd0c065e5c4aad)) and used to sign commits on GitHub. PGP key named after Keybase username.\n\nACKs for top commit:\n UdjinM6:\n utACK 315fcea83493266449a96739c7f028cdff00cc75\n knst:\n ACK 315fcea83493266449a96739c7f028cdff00cc75\n PastaPastaPasta:\n utACK 315fcea83493266449a96739c7f028cdff00cc75\n\nTree-SHA512: f566c514831cfaf0a8bf95ebfb8aa5629474bdf0b88fd8948d4c1d3f1340ccdd3a9c67c817bd08d2f4d2e477b1599bf4fd148ad50fe68357d24feba651d832f7","shortMessageHtmlLink":"Merge #6277: chore: add builder key for kittywhiskers"}},{"before":"05740e82643b948ade650d329f2af15cb134b208","after":"d754799580d2914a0dd6388c90100d14feec0428","ref":"refs/heads/develop","pushedAt":"2024-09-17T02:44:30.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6270: fix: remove mn_rr fork usage from functional test of EHF\n\n056d869571d25030635ead895d40dc340b70a3ae refactor: use testdummy in feature_mnehf functional test, removed useless checks (Konstantin Akimov)\n0351469bb579bc9f10c7eccd483431c077ec992f refactor: removed duplicated meaningless condition from Check mnhftx (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Using mn_rr in feature_mnehf.py is a blocker for burying mn_rr fork.\n\n ## What was done?\n Removed useless conditions, uses testdummy fork instead mn_rr in ehf functional test.\n\n ## How Has This Been Tested?\n Run it `test/functional/feature_mnehf.py`\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 056d869571d25030635ead895d40dc340b70a3ae\n PastaPastaPasta:\n utACK 056d869571d25030635ead895d40dc340b70a3ae\n\nTree-SHA512: aa016dc21fee3afdb5a4172e757cdd0b92867c23eb5241287f641d3c97d363ab1c46eba06423481ecc7ba05f6c0010b65eadfe77d4a1fd6074706cc6f3a71309","shortMessageHtmlLink":"Merge #6270: fix: remove mn_rr fork usage from functional test of EHF"}},{"before":"ca4b9eaad152e51703a75bb27684ad3aa4661856","after":"05740e82643b948ade650d329f2af15cb134b208","ref":"refs/heads/develop","pushedAt":"2024-09-17T02:25:59.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6271: feat: simplify and speedup feature_governance.py test by generating less blocks\n\n42dffe854103aec3f539ae112768bac40ea0ec5a chore: improve logging of functional tests feature_governance.py (Konstantin Akimov)\n922b796800140d9484a0cfa81c5185e803ffff6d feat: simplify and speedup feature_governance.py test by generating less blocks (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Too many blocks are generated in a functional tests `feature_governance.py`\n\n ## What was done?\n 1. Activate v20 faster for `feature_governance.py`, drop generation of useless blocks, simplify code.\n\n 2. Added extra logging for this test by converting comments to logs.\n\n ## How Has This Been Tested?\n Run `test/functional/feature_governance.py`\n Locally improvement of performance is less than 5 seconds.\n `tsan` jobs on CI:\n ```\n 204/264 - feature_governance.py --legacy-wallet passed, Duration: 243 s\n 208/264 - feature_governance.py --descriptors passed, Duration: 270 s\n ```\n ↑ [old version](https://gitlab.com/dashpay/dash/-/jobs/7805625816) vs [new version](https://gitlab.com/dashpay/dash/-/jobs/7819897536) ↓:\n ```\n 193/264 - feature_governance.py --legacy-wallet passed, Duration: 220 s\n 199/264 - feature_governance.py --descriptors passed, Duration: 240 s\n ```\n\n Most of the time is spent in `feature_governance.py` on stage \"let all fulfilled requests expire for re-sync to work correctly\" so that's a very minor optimization.\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 42dffe854103aec3f539ae112768bac40ea0ec5a\n PastaPastaPasta:\n utACK 42dffe854103aec3f539ae112768bac40ea0ec5a\n\nTree-SHA512: 9257301043efca8b3775fff64e598b153e00bc48779212e6237ab63f06a043a66764d72e38d9e6071b82477e55884b9bce410f4d3fabeb13da631505113e86bc","shortMessageHtmlLink":"Merge #6271: feat: simplify and speedup feature_governance.py test by…"}},{"before":"d290df38edf407f54df67f239b485a72979a4bea","after":"ca4b9eaad152e51703a75bb27684ad3aa4661856","ref":"refs/heads/develop","pushedAt":"2024-09-16T17:01:24.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6255: backport: merge bitcoin#24531, #25500, #25814, #25962, #26888, #27264, #27257, #27324, #27374, #27467, #27411, partial bitcoin#25472 (networking backports: part 8)\n\n8320e0ca8ea3adda8dd672f716bf6214d034e5de merge bitcoin#27411: Restrict self-advertisements with privacy networks to avoid fingerprinting (Kittywhiskers Van Gogh)\n1376289b11c624a2b648ae1b117d398303e10bfa merge bitcoin#27467: skip netgroup diversity follow-up (Kittywhiskers Van Gogh)\na52b3a3bf0891bed8822453e45d310160cf6dd8f merge bitcoin#27374: skip netgroup diversity of new connections for tor/i2p/cjdns (Kittywhiskers Van Gogh)\nab11e0f998cf41f62e4f3601eb21f134c6f4994a merge bitcoin#27324: bitcoin#27257 follow-ups (Kittywhiskers Van Gogh)\n9023dd25af698ee163bc5438f84588f09221f61c merge bitcoin#27257: End friendship of CNode, CConnman and ConnmanTestMsg (Kittywhiskers Van Gogh)\n3465df2689ea7b9fbdb67fc41afc90f705d20dde merge bitcoin#27264: Improve diversification of new connections (Kittywhiskers Van Gogh)\nd3f5b3881b80b3d590bb20ec60199b89dde3f7dd merge bitcoin#26888: simplify the call to vProcessMsg.splice() (Kittywhiskers Van Gogh)\nd9e56f3e780f597de1f7bf4ec88fce345267253b merge bitcoin#25962: Add CNodeOptions and increase constness (Kittywhiskers Van Gogh)\n79e67fd96a3ba1680fd24ac0110faa8ea1464c84 merge bitcoin#25814: simplify GetLocalAddress() (Kittywhiskers Van Gogh)\n6d4945418a472d9e25721baf3f767ca7f35c0781 partial bitcoin#25472: Increase MS Visual Studio minimum version (Kittywhiskers Van Gogh)\n54bb3a438f6fc843863ac8dbf476bd22606440db merge bitcoin#25500: Move inbound eviction logic to its own translation unit (Kittywhiskers Van Gogh)\nb50febc0f0d0bfcd5cf5a92ef9a79302b71acb6d merge bitcoin#24531: Use designated initializers (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * Dependent on https://github.com/dashpay/dash/pull/6254\n * When backporting [bitcoin#27411](https://github.com/bitcoin/bitcoin/pull/27411), the `CNetAddr*` variant of `GetLocal()` was not removed (upstream it was replaced by the `CNode&` variant with additional checks that rely on fields in `CNode`) as `CActiveMasternodeManager` relies on `GetLocal()` to detect a valid external address.\n * While it can also rely on other nodes to determine that, removing code that tests against a well-known public address would increase the number of reported failures esp. if the checks are run _before_ the node has a chance to connect to any peers.\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 8320e0ca8ea3adda8dd672f716bf6214d034e5de\n PastaPastaPasta:\n utACK 8320e0ca8ea3adda8dd672f716bf6214d034e5de\n\nTree-SHA512: 1d02bc33c8d62c392960d4dd044edf3de08515a5e8c8794d95cd95e9654da91b20e7290436cf9c79b0ea8dbd42b27dcc61c8eb17e573902574d7b281b8874584","shortMessageHtmlLink":"Merge #6255: backport: merge bitcoin#24531, bitcoin#25500, bitcoin#25814"}},{"before":"17110f50b3adb1b8a51348259e752a760ab3ee0a","after":"d290df38edf407f54df67f239b485a72979a4bea","ref":"refs/heads/develop","pushedAt":"2024-09-15T03:58:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6273: backport: merge bitcoin#27015 (resolve flaky addrman unit test)\n\n925870d7d0ea97fba101f9ba67a72d73d46fbbda merge bitcoin#27015: bitcoin#26847 fixups (AddrMan totals) (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n As part of [dash#6254](https://github.com/dashpay/dash/pull/6254), [bitcoin#26847](https://github.com/bitcoin/bitcoin/pull/26847) was backported and since then, it was observed that unit tests were flakier than expected ([build](https://gitlab.com/dashpay/dash/-/jobs/7811041841), [build](https://gitlab.com/dashpay/dash/-/jobs/7802460298)).\n\n The flakiness was caused by behavior introduced by the aforementioned backport, this was resolved upstream with [bitcoin#27015](https://github.com/bitcoin/bitcoin/pull/27015), which this pull request contains.\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 925870d7d0ea97fba101f9ba67a72d73d46fbbda\n knst:\n ACK 925870d7d0ea97fba101f9ba67a72d73d46fbbda\n\nTree-SHA512: 20fc8fb1b162803a71ec4087685460f52ed56c3c86d46ecac4cc0ef59c95b4b6206f0c53bef256242a4a5babb76e3564cfba56a84cbe844e187035de2308b818","shortMessageHtmlLink":"Merge #6273: backport: merge bitcoin#27015 (resolve flaky addrman uni…"}},{"before":"96685be6857e5789e621b1ffe0b71c47d2c2ace7","after":"17110f50b3adb1b8a51348259e752a760ab3ee0a","ref":"refs/heads/develop","pushedAt":"2024-09-12T14:41:43.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6254: backport: merge bitcoin#25678, #26040, #26847, #25619, #27214, #26261, #27745, #27529, #28341, partial bitcoin#25331 (addrman backports: part 4)\n\ne544d3c741b79ab72b58f255e352e49a096a746d fmt: apply `clang-format-diff.py` suggestions, satisfy linter (Kittywhiskers Van Gogh)\n7da74ffcd56305555aecc4a3d6b2be9e3c53cedf merge bitcoin#28341: Use HashWriter over legacy CHashWriter (Kittywhiskers Van Gogh)\nc798b496cd7613900d46894054c0f2550f78bd4d merge bitcoin#27529: fix `feature_addrman.py` on big-endian systems (Kittywhiskers Van Gogh)\n7d149c97be976f4c0a429b6107aa40856993750e merge bitcoin#27745: select addresses by network follow-up (Kittywhiskers Van Gogh)\n1d829943835326c34ba618266a78f0488b20fd57 merge bitcoin#26261: cleanup `LookupIntern`, `Lookup` and `LookupHost` (Kittywhiskers Van Gogh)\n231ff82c2eb89bfc375e6076272a9ffa52c3bb26 merge bitcoin#27214: Enable selecting addresses by network (Kittywhiskers Van Gogh)\ne82559516ca25e932c30aa252154c6df6e01cf10 merge bitcoin#25619: avoid overriding non-virtual ToString() in CService and use better naming (Kittywhiskers Van Gogh)\n2e9b48a910779ad21d15eda08c8974699af90d53 merge bitcoin#26847: track AddrMan totals by network and table, improve precision of adding fixed seeds (Kittywhiskers Van Gogh)\n79a550ec15f5d5d89105f2d1747419025d67d18e merge bitcoin#26040: comment \"add only reachable addresses to addrman\" (Kittywhiskers Van Gogh)\n1adb635ec641dc1b20f79726c2a20a4e75558b60 merge bitcoin#25678: skip querying dns seeds if -onlynet disables IPv4 and IPv6 (Kittywhiskers Van Gogh)\n2d99be0aea06e81c0ee84dacf213f70663d3966f partial bitcoin#25331: Add HashWriter without ser-type and ser-version (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * Dependent on https://github.com/dashpay/dash/pull/6243\n\n * Dependent on https://github.com/dashpay/dash/pull/5167\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK e544d3c741b79ab72b58f255e352e49a096a746d\n\nTree-SHA512: 63f014142c39c47bda3ac85dc6afeee8f2bfec71f033631bca16d41bb0785f4b090b3c860ddc3b3cf6c4a23558d3d102144fc83b065130c3f9ab91d0de8e4457","shortMessageHtmlLink":"Merge #6254: backport: merge bitcoin#25678, bitcoin#26040, bitcoin#26847"}},{"before":"f2645df7d366ae8e067d5340358b835196dd2dad","after":"96685be6857e5789e621b1ffe0b71c47d2c2ace7","ref":"refs/heads/develop","pushedAt":"2024-09-11T16:18:05.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #5167: refactor(stats): modernize `statsd::StatsdClient`, make global `unique_ptr`\n\ncc998abec16bfb1f2d55d92e4c0e6a495576c775 fmt: apply `clang-format-diff.py` suggestions (Kittywhiskers Van Gogh)\n0401c581eb3f4ea2303c9390d81ac081980af953 stats: `const`-ify variables and arguments (Kittywhiskers Van Gogh)\n9f967237742d3d19ece2fdbc294808f83d47073b stats: stop using error codes, switch over to `bool` (Kittywhiskers Van Gogh)\n1a81979c1e8cf47df28d785689b4049e1504d0d1 stats: initialize socket after we have a valid socket address (Kittywhiskers Van Gogh)\ndbbfc8d766903569ee99759c1b331e55a4dbd306 stats: use `Socks` wrapper, use `CService` to generate our `sockaddr` (Kittywhiskers Van Gogh)\n2def905044702dc9c9149b07d8a0bae17badd0d5 stats: move init logic into constructor (Kittywhiskers Van Gogh)\n4bc727cd6c235415f63a076f0377043959f10b60 stats: clean up randomization code, move `FastRandomContext` inward (Kittywhiskers Van Gogh)\n840241eefd7c65abd39a73fc1831976ab0694ecb stats: cleanup error logging, improve code sanity (Kittywhiskers Van Gogh)\n85890ddb1370fc625101e37f7bfb225c24f973ff docs: add copyright notice to source file, update notice in header (Kittywhiskers Van Gogh)\na9d1b1494d4f430531c8f4345d63576d454a1e2e stats: move `_StatsdClientData` variables into `StatsdClient` (Kittywhiskers Van Gogh)\n30c30c1397d23fbe6b6e7da57c2b52e97d1899c9 stats: fetch all arguments needed when constructing `g_stats_client` (Kittywhiskers Van Gogh)\n5133d88415bdff2e32a921d3ee10f5e81920d91b stats: s/statsClient/g_stats_client/g (Kittywhiskers Van Gogh)\nf81951dd00f11d860ef9c249680d27506b19a706 stats: make `statsClient` a `std::unique_ptr`, denote as global variable (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n Support for transmitting stats to a Statsd server has been courtesy of Statoshi ([repo](https://github.com/jlopp/statoshi)), implemented Dec, 2020 by [dash#2515](https://github.com/dashpay/dash/pull/2515) but since then, it hasn't gotten much attention aside from benefiting from codebase-wide changes and the occasional compiler appeasement. This pull request aims to give our statistics code some TLC.\n\n Changes include:\n\n * Limiting initialization to solely during construction and moving the responsibility of fetching arguments outside of `statsd::StatsdClient`.\n * Using the RAII `Socks` wrapper as early as possible (we still need to construct a raw socket ourselves but this is done in the initializer and control is moved to the wrapper and everywhere else, the wrapper is used)\n * Utilizing existing networking code to generate the socket address\n * This lets us trivially allow IPv6 connections as the responsibility to construct it safely is moved to `CService`.\n * Using `std::string` and our string manipulation capabilities (replacing `snprintf` with `strprintf`), replacing platform-specific types (replacing `short` with `uint16_t`).\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n PastaPastaPasta:\n utACK [cc998ab](https://github.com/dashpay/dash/pull/5167/commits/cc998abec16bfb1f2d55d92e4c0e6a495576c775)\n UdjinM6:\n utACK cc998abec16bfb1f2d55d92e4c0e6a495576c775\n\nTree-SHA512: 433c92160d6ac7ebb8582ada3cbb65ead7913618266b773619a528c90dfe0e286aafa46dc3b0bca62f246938e5948a732080e2cddba942d3627f007ca6efcc1f","shortMessageHtmlLink":"Merge #5167: refactor(stats): modernize statsd::StatsdClient, make …"}},{"before":"6019a8708f2fbc20a57375c871df2ff33861d3be","after":"f2645df7d366ae8e067d5340358b835196dd2dad","ref":"refs/heads/develop","pushedAt":"2024-09-11T16:11:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6262: chore: add `stats` as a pull request header type and scope\n\n4faf35f7491f8213a36d1652010bcc2bdff94c1d chore: add `stats` as a pull request header scope (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n Would allow tagging https://github.com/dashpay/dash/pull/5167, https://github.com/dashpay/dash/pull/6267 and https://github.com/dashpay/dash/pull/6237 as `feat(stats)`.\n\n ## Breaking Changes\n\n None.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code **(note: N/A)**\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ **(note: N/A)**\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 4faf35f7491f8213a36d1652010bcc2bdff94c1d\n UdjinM6:\n utACK 4faf35f7491f8213a36d1652010bcc2bdff94c1d\n thephez:\n utACK 4faf35f7491f8213a36d1652010bcc2bdff94c1d\n\nTree-SHA512: 25cc28792351852b9e920d980b8814d93274bc53d22ce63fb1a5bf32821b10902d22b384a408e1c4a7b97239e53e235c45ac008d0f82e1afe5d6071b392acb47","shortMessageHtmlLink":"Merge #6262: chore: add stats as a pull request header type and scope"}},{"before":"4d312b54565bff449a1d8f8cad55d7159009b973","after":"6019a8708f2fbc20a57375c871df2ff33861d3be","ref":"refs/heads/develop","pushedAt":"2024-09-11T14:53:42.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6260: backport: merge bitcoin#20018, #22141, #22221, #22653, #23054, #23398, #23175, #22362, #23769, #23936, #24238, #24331 (auxiliary backports: part 15)\n\n6c7335e002c3b8018606cd857460c646da162b3d merge bitcoin#24331: Revert back `MoveFileExW` call for MinGW-w64 (Kittywhiskers Van Gogh)\n15e794bdd83c4bf7ba37a2e83af6cd581fe37c20 merge bitcoin#24238: use arc4random on OpenBSD (Kittywhiskers Van Gogh)\ne039aecbdcc32923165943195584bb32f0bd2f7f merge bitcoin#23936: Add and use EnsureArgsman helper (Kittywhiskers Van Gogh)\nb4bfacfd2465f3d0bf56eff9bceec10825642d37 merge bitcoin#23769: Disallow copies of CChain (Kittywhiskers Van Gogh)\n5b6668816017181598511c4dfac48a639816d9c7 merge bitcoin#22362: Drop only invalid entries when reading banlist.json (Kittywhiskers Van Gogh)\n109c963f6a3e278df85d642c56590129a8082cc5 merge bitcoin#23175: Add CJDNS network to -addrinfo and -netinfo (Kittywhiskers Van Gogh)\nd57c96ea37dc3555a109d22d7285b0326d4cee6f merge bitcoin#23398: add return message to savemempool RPC (Kittywhiskers Van Gogh)\n22e59fb46441c8f656928550af7bb3be0afe26b4 merge bitcoin#23054: Use C++11 member initializer in CTxMemPoolEntry (Kittywhiskers Van Gogh)\nd158063b6d503de41d51d73dfda328e35b466101 merge bitcoin#22653: Rename JoinErrors and re-use it (Kittywhiskers Van Gogh)\ne24324d266dbdbdab07ed706c981f6eba17085fb merge bitcoin#22221: Pass block reference instead of pointer to PeerManagerImpl::BlockRequested (Kittywhiskers Van Gogh)\n68657efc03a89eda4b6746db669bd5a0c53bd250 merge bitcoin#22141: net processing: Remove hash and fValidatedHeaders from QueuedBlock (Kittywhiskers Van Gogh)\nc0e6792e27026768fb88b0f892c037c75221027d merge bitcoin#20018: ProcessAddrFetch(-seednode) is unnecessary if -connect is specified (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * When backporting [bitcoin#23054](https://github.com/bitcoin/bitcoin/pull/23054), `sigOpCount` and `nSigOpCountWithAncestors` were switched from `unsigned int` to `int64_t`. This change was done to prevent integer narrowing when accepting the `int64_t` taken from the constructor.\n\n This isn't a problem upstream as the same changes were as part of [bitcoin#8149](https://github.com/bitcoin/bitcoin/pull/8149/files#diff-8a2230436880b65a205db9299ab2e4e4adb1d4069146791b5db566f3fb752adaL90-L107), which was omitted but the type changes remain valid as sigop count cannot be a negative number.\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 6c7335e002c3b8018606cd857460c646da162b3d\n UdjinM6:\n utACK 6c7335e002c3b8018606cd857460c646da162b3d\n\nTree-SHA512: 29cae42dd82235305d3558562bae346170e742ce0b65897e396b331294b39cad0dd831fa9a09b34780a67844e55292e5b4e784cf544a894cc3f8897afe617ca1","shortMessageHtmlLink":"Merge #6260: backport: merge bitcoin#20018, bitcoin#22141, bitcoin#22221"}},{"before":"1464e69058684762143f2a41165d5ed554e7779e","after":"4d312b54565bff449a1d8f8cad55d7159009b973","ref":"refs/heads/develop","pushedAt":"2024-09-11T13:19:06.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6252: test: Improve tests robustness\n\n0c5179462e92ff0d443c4670748ceb8a19cf8736 test: rework feature_governance_cl.py (UdjinM6)\n11ac0819dad89c480779f1ab18c959a777fed6a1 feat: bump_mocktime also bumps schedulers now (UdjinM6)\n1937f503fe47fcf205914ce9ce18c5a42fb17906 feat: regtest-only: do not auto-reset mnsync after 1h (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n 1. The original idea behind forced reset was to help desktop clients which go into sleep/hibernation mode from time to time to sync with no issues once they are online again. For regtest however it doesn't do anything good and only causes issues.\n 2. We rely on schedulers a lot, bumping them should let nodes behave more like on a real network.\n 3. Forcing mnsync to skip governance votes doesn't always work as we'd expect cause we don't control connection creation. To make it more deterministic create a proposal that should get into one superblock only. This way both the proposal and the trigger will expire/be deleted after another superblock meaning we can be 100% sure the isolated node never gets any of them and can only sync thanks to chainlock.\n\n ## What was done?\n\n ## How Has This Been Tested?\n run tests\n\n ## Breaking Changes\n n/a\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 0c5179462e92ff0d443c4670748ceb8a19cf8736\n\nTree-SHA512: 9a40eeaba880f3f27f86736e92afa19a4ecb2a2d157bc42b65dd9da0d4109c9cd1d83a5abdf1ec16be2f8a8b31821fb700a7f0d2265c094fd4fdff7f18bc6ec7","shortMessageHtmlLink":"Merge #6252: test: Improve tests robustness"}},{"before":"6d426515a51d31c4d153e8c853ec84aaf0707c83","after":"1464e69058684762143f2a41165d5ed554e7779e","ref":"refs/heads/develop","pushedAt":"2024-09-10T15:21:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6148: feat: broadcast dsq messages using the inventory system\n\n57fb0874ef180cd9aa8b7800a2a0842e2faba65e feat: broadcast dsq messages using the inventory system (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n DSQ messages are 142 bytes.\n\n Previously, assuming a relatively highly connected masternode hosting 100 connection, each round of coinjoin will result in 14.2KB (100*142) of inbound and outbound traffic each.\n\n ## What was done?\n Now, using the inventory system, a message will first use 36 bytes per peer (sending and receiving), plus the size of a `getdata` message and the actual message itself. As a result, bandwidth usage for 1 round of mixing would be closer to 36 * 100 + 142 (dsq) + 36 (getdata) = ~3.8KB, a reduction of around ~73%\n\n ## How Has This Been Tested?\n Has not been; @UdjinM6 especially please review well :)\n\n ## Breaking Changes\n Does introduce a new protocol version, but in a backwards compatible way. I don't think this would need to be delayed to v22 for any reason.\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nTop commit has no ACKs.\n\nTree-SHA512: 3dc39a339cba29d8cf207cec76ecace5ad0e11d1892ca0f65f9253a2b1d90313da21c6c178c2476756c5566ece0fab777006cd609b7984df906a9206c25d921d","shortMessageHtmlLink":"Merge #6148: feat: broadcast dsq messages using the inventory system"}},{"before":"0c243ab4f512f338ca6190b705ebb506e9e170f5","after":"6d426515a51d31c4d153e8c853ec84aaf0707c83","ref":"refs/heads/develop","pushedAt":"2024-09-10T13:50:29.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6225: feat: bury v20 fork - fire up test chains by first block - 4/n\n\n23812555b181746503d8bde2f1ec0b0fe3a9926f fix: possible deadlock during calculation of signals for historical blocks during re-index (Konstantin Akimov)\n1087489fd48a5676f7c269d1e6b3106e73e2b339 feat: bury v20 deployment (Konstantin Akimov)\n64cedb30bd126e48ef80ef9e92c90ce4c274d712 feat: actually test something EHF unit tests (Konstantin Akimov)\n762a808b8c1257a6e1e67c1f21305a22ac7d467f chore: drop irrelevant bip9 code from feature_llmq_rotation.py (Konstantin Akimov)\n7735631aadd3edd13b625099bee3ee37f601ab51 fix: remove v20 from test feature_llmq_evo as far as mn_rr used (Konstantin Akimov)\nca83b2681500f0f2b0003be2057850b821cad2f0 fix: crash in CreditPool: it meant to check that DIP0003 is activated (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n V20 is activated on mainnet: time to bury it!\n\n https://github.com/dashpay/dash/issues/6186\n\n ## What was done?\n Hard-fork v20 is buried and it requires to implement multiple fixes, simplifications, refactoring:\n - some tests for EHF moved from functional tests to unit tests\n - fixed crash in Credit Pool if DIP3 is not activated yet\n - added a requirement for v20 activation for `CMNHFManager::GetSignalsStage`\n - removed useless code from functional test feature_llmq_rotation\n - renamed variables \"v20\" to \"mn_rr\" in feature_llmq_evo.py so far as actually used fork is mn_rr\n\n ## How Has This Been Tested?\n Some unit and functional tests to succeed.\n\n Done reindex (just in case):\n\n src/qt/dash-qt -reindex -assumevalid=0\n src/qt/dash-qt -reindex -assumevalid=0 -testnet\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n ACK 23812555b181746503d8bde2f1ec0b0fe3a9926f\n PastaPastaPasta:\n utACK https://github.com/dashpay/dash/commit/23812555b181746503d8bde2f1ec0b0fe3a9926f\n\nTree-SHA512: eec35745baa695f3f286d39b6a61fa0a9f34820b13d1dd4cfbd1efe707850283892c39bf7fe49c49c812e0c02465d64df11480b3f12aa7f21b59a71eeae7260e","shortMessageHtmlLink":"Merge #6225: feat: bury v20 fork - fire up test chains by first block…"}},{"before":"8c106bb9ceb30fdb9dba58e89a17807fe42bb7a2","after":"0c243ab4f512f338ca6190b705ebb506e9e170f5","ref":"refs/heads/develop","pushedAt":"2024-09-06T19:20:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6253: ci: fix, in github actions CI actually check out the PR\n\nfb92a8ef7bfcc42fc973893334191aa5ff77c64e ci: fix, in github actions CI, we don't actually check out the PR, but the base (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Actually check out the PR for GitHub actions CI. I knew this was an issue for a lil bit since we implemented it. Time to fix it.\n\n Note: Github Actions based CI is experimental, and we still primarily use GitLab. Functionals tests don't even run on GitHub Actions CI yet.\n\n ## What was done?\n Check out the actual PR commit\n\n ## How Has This Been Tested?\n\n ## Breaking Changes\n None\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK fb92a8ef7bfcc42fc973893334191aa5ff77c64e\n\nTree-SHA512: 31b3737328ac66217c66c99efce6a3ccfe9e8b9a2453a8b226c12c394e2433828d20165a9dfa4c9463ae4fa5015a7d07f451dde98e937a230e04087383230a02","shortMessageHtmlLink":"Merge #6253: ci: fix, in github actions CI actually check out the PR"}},{"before":"f222f798ab611f5897e610ca14e15d98216520c4","after":"8c106bb9ceb30fdb9dba58e89a17807fe42bb7a2","ref":"refs/heads/develop","pushedAt":"2024-09-06T03:29:47.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6249: ci: improve conflicts checker to skip PRs which are a draft\n\n2e8f9f9f084f04d18c09d0e9a34d30e7fe99a085 refactor: better readability (UdjinM6)\n9ad537380be3157c73366916023a94ebbd165aa1 ci: less api calls when checking potential conflicts (UdjinM6)\n9f3d5b08c714b181300fd3184393985ca3d55884 ci: improve conflicts checker to skip PRs which are a draft (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Currently, CI will report a lot of conflicts on most normal PRs. This is because a lot of times a WIP PR will be opened which depends on another. This will result in both being unhappy.\n\n ## What was done?\n Instead, skip any PR which is considered a draft.\n\n ## How Has This Been Tested?\n Hasn't, wish us luck!\n\n ## Breaking Changes\n None\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 2e8f9f9f084f04d18c09d0e9a34d30e7fe99a085\n\nTree-SHA512: 3c498d406244bf288df21dc57b28120d2f50c409c1cf1311e3681647bc76d435910e7bb81e9bf6441c057644602324b8be451e66a9fc19a28be30100a7c70087","shortMessageHtmlLink":"Merge #6249: ci: improve conflicts checker to skip PRs which are a draft"}},{"before":"93e62f3e781c806d6efcd271685621744314e2c2","after":"f222f798ab611f5897e610ca14e15d98216520c4","ref":"refs/heads/develop","pushedAt":"2024-09-05T17:49:52.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6155: fix: avoid voting for the same trigger multiple times\n\ne92aad7cff1d8b02843f54b4b3e398f2b31223ea test: make sure MNs don't vote twice even when they are allowed to (UdjinM6)\n3d75390e4ec590dc06de8554b16d1d10735dd23a fix: correct conditions for YES voting (UdjinM6)\nec1392c6dec3f945d889561a789fe3a769906b7f chore: make clang-format and linter happy (UdjinM6)\na6320865c46b2af0ec89c830c868e7aeec96d187 fix: avoid voting for the same trigger multiple times (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n We just had a sb voting period and I noticed that the network is way too spammy and produces too many votes (10x+ the expected numbers). It turns out that relying on `ProcessVoteAndRelay` on mainnet is not enough because rate-check expires too soon and MNs are able to vote again and again. On testnet it was never an issue because the voting period there is really short.\n\n ## What was done?\n Check known votes to make sure we never voted earlier.\n\n ## How Has This Been Tested?\n Run tests, run a MN on mainnet and check logs.\n\n ## Breaking Changes\n n/a\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n PastaPastaPasta:\n utACK e92aad7cff1d8b02843f54b4b3e398f2b31223ea\n\nTree-SHA512: 142e23d3a19fa9527fa5257eb790e558d3507a7a857f17c6e02fd58eeb5643fcfb48d824d227e0ea7cd3dae6a6d7d871b3af88b13077f5af074ed1911e42bb28","shortMessageHtmlLink":"Merge #6155: fix: avoid voting for the same trigger multiple times"}},{"before":"b38c4d3c1bfcf3a3634608719d821e14155e2876","after":"93e62f3e781c806d6efcd271685621744314e2c2","ref":"refs/heads/develop","pushedAt":"2024-09-05T17:13:25.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6232: backport: merge bitcoin#22006, #22955, #23375, #23302, #22902, #23724, #26944, #23907, #24358, #25360, #25794, #26945, #27458, #28110 (userspace static defined tracing)\n\n0a7a234bd3a1dbeb34ab981485a42d32d9d35985 merge bitcoin#28110: correct Fedora systemtap dep (Kittywhiskers Van Gogh)\nc92eb67c40244e21bc8f8005f8b3232db9e3ac7e merge bitcoin#27458: Detect USDT the same way how it is used in the code (Kittywhiskers Van Gogh)\nf4a53ba8ce229dd5876b70084882cd6c4b7fd422 merge bitcoin#26945: systemtap 4.8 (Kittywhiskers Van Gogh)\n88696129f33b3958c7b14e995c64d6a09f438503 merge bitcoin#25794: don't rely on block_connected USDT event order in tests (Kittywhiskers Van Gogh)\n457bbd3f8b5121d5a54bf29d16b37588a7fe52f2 merge bitcoin#25360: SystemTap 4.7 (RISC-V support) (Kittywhiskers Van Gogh)\nf3b219ad0d91c03d2050d679a3614119862f7678 merge bitcoin#24358: USDT tracepoint interface tests (Kittywhiskers Van Gogh)\n5b10a5a2fd2e0d4506f87268f1559f1d8f11adff merge bitcoin#23907: utxocache tracepoints follow up (Kittywhiskers Van Gogh)\nc3d7e3a1920416f82e953204358e50c303e4abed merge bitcoin#26944: fix systemtap download URL (Kittywhiskers Van Gogh)\n264e02fcc72e55fd42c94847e73dd6d792925bf9 merge bitcoin#23724: add systemtap's sys/sdt.h as depends for GUIX builds with USDT tracepoints (Kittywhiskers Van Gogh)\n6cc596b99a8b547abb0c9867d630ca059f07748f merge bitcoin#22902: utxocache tracepoints (Kittywhiskers Van Gogh)\n644a47ef9a5886e6ec560b4deacc7b549a6272de merge bitcoin#23302: drop GetHash().ToString() argument from the `validation:block_connected` tracepoint (Kittywhiskers Van Gogh)\nbfdc9ad364ab5c8d4c3a44e766b4246e4dfefc13 merge bitcoin#23375: more deterministic coin selection for coinbase UTXOs (oldest first) (Kittywhiskers Van Gogh)\n5718716cd28de1102876c52da67d770b9f4b1666 merge bitcoin#22955: Rename fBlocksOnly, Add test (Kittywhiskers Van Gogh)\ncacc31213b14864d32fda0d1ba0b8b41938d1d39 merge bitcoin#22006: first tracepoints and documentation on User-Space, Statically Defined Tracing (USDT) (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * In [bitcoin#22955](https://github.com/bitcoin/bitcoin/pull/22955), `fBlocksOnly` has not been renamed to `reject_tx_invs` as Dash uses the inventory system beyond relaying transaction data with the block-relay-only blocklist have a greater set of prohibited messages. This renders the new name misleading but coining a new name may be a source of confusion, making retaining the legacy name desirable.\n\n * Additionally, because the word \"transaction\" isn't hardcoded into the log message (instead opting to use `CInv::GetCommand()`'s output instead, which for transactions, are \"tx\"), the expected log message in `p2p_blocksonly.py` has been adjusted accordingly.\n\n * [bitcoin#24358](https://github.com/bitcoin/bitcoin/pull/24358) depends on [bitcoin#22955](https://github.com/bitcoin/bitcoin/pull/22955) and [bitcoin#23375](https://github.com/bitcoin/bitcoin/pull/23375) in order to work as without the latter backport, `interface_usdt_utxocache.py` will return the following error\n\n \n\n Test run:
\n\n ```\n debian@debian:~/dash$ sudo ./test/functional/interface_usdt_utxocache.py\n [sudo] password for debian:\n 2024-08-26T17:08:05.234000Z TestFramework (INFO): Initializing test directory /tmp/dash_func_test_n5rb0xy4\n 2024-08-26T17:08:07.023000Z TestFramework (INFO): testing the utxocache:uncache tracepoint API\n 2024-08-26T17:08:07.026000Z TestFramework (ERROR): Assertion failed\n Traceback (most recent call last):\n File \"/home/debian/dash/test/functional/test_framework/test_framework.py\", line 160, in main\n self.run_test()\n File \"/home/debian/dash/./test/functional/interface_usdt_utxocache.py\", line 149, in run_test\n self.test_uncache()\n File \"/home/debian/dash/./test/functional/interface_usdt_utxocache.py\", line 172, in test_uncache\n invalid_tx = self.wallet.create_self_transfer(\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/home/debian/dash/test/functional/test_framework/wallet.py\", line 166, in create_self_transfer\n assert_equal(mempool_valid, tx_info['allowed'])\n File \"/home/debian/dash/test/functional/test_framework/util.py\", line 51, in assert_equal\n raise AssertionError(\"not(%s)\" % \" == \".join(str(arg) for arg in (thing1, thing2) + args))\n AssertionError: not(True == False)\n 2024-08-26T17:08:07.533000Z TestFramework (INFO): Stopping nodes\n 2024-08-26T17:08:08.535000Z TestFramework (WARNING): Not cleaning up dir /tmp/dash_func_test_n5rb0xy4\n 2024-08-26T17:08:08.535000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/dash_func_test_n5rb0xy4/test_framework.log\n 2024-08-26T17:08:08.535000Z TestFramework (ERROR):\n 2024-08-26T17:08:08.535000Z TestFramework (ERROR): Hint: Call /home/debian/dash/test/functional/combine_logs.py '/tmp/dash_func_test_n5rb0xy4' to consolidate all logs\n 2024-08-26T17:08:08.536000Z TestFramework (ERROR):\n 2024-08-26T17:08:08.536000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.\n 2024-08-26T17:08:08.536000Z TestFramework (ERROR): https://github.com/dashpay/dash/issues\n 2024-08-26T17:08:08.536000Z TestFramework (ERROR):\n ```\n\n \n\n with the underlying error that has been alluded to in d2c4904\n\n ```\n {'txid': '44b58b10e69321dacf00724f1893c9ecb50fc1f89ed7c70a6c0b3c08f7dc750f', 'allowed': False, 'reject-reason': 'bad-txns-premature-spend-of-coinbase'}\n ```\n\n * In [bitcoin#24358](https://github.com/bitcoin/bitcoin/pull/24358), all `interface_usdt_*.py` tests needed minor syntax changes to account for how we invoke certain RPCs. `interface_usdt_utxocache.py` required tweaking with the blocks needed to be eligible for pruning (`450` vs. `350` upstream) and stop the node explicitly to account for the governance validation warning .\n\n This is important as the placement assumes that `test_flush()` is the last test, should this change, the node may need to be manually started before continuing on with the tests after.\n\n * Some `TRACE*` entries may not exactly match the backports they come from because the variables or functions they access may have been amended by a backport done _after_ the backport that introduce the trace entry.\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 0a7a234bd3a1dbeb34ab981485a42d32d9d35985\n PastaPastaPasta:\n utACK [0a7a234](https://github.com/dashpay/dash/pull/6232/commits/0a7a234bd3a1dbeb34ab981485a42d32d9d35985)\n\nTree-SHA512: 8df11392dd8d152c18d55ac70a446d1eec336bdf1a984cbf41c3202c353358180e05ba4b7182ec2962ea09eefa41d1dc3cd383d358f9b3dec57ce8b67c6e6afd","shortMessageHtmlLink":"Merge #6232: backport: merge bitcoin#22006, bitcoin#22955, bitcoin#23375"}},{"before":"18625ae559066574b91a2a5012fc3de2854ae43e","after":"b38c4d3c1bfcf3a3634608719d821e14155e2876","ref":"refs/heads/develop","pushedAt":"2024-09-05T14:38:36.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6229: fix: `creditOutputs` in AssetLock tx json output should be an array of objects, not debug strings\n\n9876c2d78b0df7eee802cf3b90529fdcacdf1c2c docs: add partial release notes (UdjinM6)\nb330318db788129eab69ed91c755b31cafa03c8f refactor: drop circular dependency (UdjinM6)\ne54fe42ce85b0ace8291699f3ecce2e52e638d27 refactor: use `key_to_p2pkh_script` in more places (UdjinM6)\n3ed62468898eb45c124ac02ce35fac315606fb40 test: check `creditOutputs` format (UdjinM6)\nba0e64505b7bc97f9e5da3e457f89db77040e97f fix: `creditOutputs` in AssetLock tx json output should be an array of objects, not debug strings (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Txout-s in `creditOutputs` for AssetLock txes should be shown the way txout-s are shown in other places. We should not be using debug strings there.\n\n Example: `getrawtransaction 50757f651f335e22c5a810bd05c1e5aac0d95b132f6454e2a72683f88e3983f3 1`\n\n develop:\n ```\n \"assetLockTx\": {\n \"version\": 1,\n \"creditOutputs\": [\n \"CTxOut(nValue=0.01000000, scriptPubKey=76a914cdfca4ae1cf2333056659a2c)\"\n ]\n },\n ```\n This PR:\n ```\n \"assetLockTx\": {\n \"version\": 1,\n \"creditOutputs\": [\n {\n \"value\": 0.01000000,\n \"valueSat\": 1000000,\n \"scriptPubKey\": {\n \"asm\": \"OP_DUP OP_HASH160 cdfca4ae1cf2333056659a2c8dc656f36d228402 OP_EQUALVERIFY OP_CHECKSIG\",\n \"hex\": \"76a914cdfca4ae1cf2333056659a2c8dc656f36d22840288ac\",\n \"address\": \"yf6c2VSpWGXUgmjQSHRpfEcTPsbqN4oL4c\",\n \"type\": \"pubkeyhash\"\n }\n }\n ]\n },\n ```\n kudos to @coolaj86 for finding the issue\n\n ## What was done?\n Change `CAssetLockPayload::ToJson()` output to be closer to [`TxToUniv()`](https://github.com/dashpay/dash/blob/develop/src/core_write.cpp#L262-L272)\n\n NOTE: `refactor: use key_to_p2pkh_script in more places` commit is a bit unrelated but I decided to add it anyway to make it easier to follow assetlock creation vs getrawtransaction rpc check.\n\n ## How Has This Been Tested?\n Try example above, run tests\n\n ## Breaking Changes\n RPC output is different for AssetLock txes\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 9876c2d78b0df7eee802cf3b90529fdcacdf1c2c\n\nTree-SHA512: 158c98ac9e4979bb29c4f54cb1b71806f22aaec92218d92cd2b2e9b9f74df721563e7a6c5f517ea358ac74659fa79f51d1b683002a1cdceb1b8ee80f8fd79375","shortMessageHtmlLink":"Merge #6229: fix: creditOutputs in AssetLock tx json output should …"}},{"before":"ddc53d7afd0ce6e3e3f3e996196845378ada3e8c","after":"18625ae559066574b91a2a5012fc3de2854ae43e","ref":"refs/heads/develop","pushedAt":"2024-09-04T17:44:56.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6243: backport: merge bitcoin#22226, #22831, #23084, #22872, #23477, #23492, #23713, #23780, #23826, #23373, #24201, #24665, #22910, partial bitcoin#23025 (addrman backports: part 3)\n\nf0321194564bb50a71aafd48c04d0db262efdaaa merge bitcoin#22910: Encapsulate asmap in NetGroupManager (Kittywhiskers Van Gogh)\n8020bfa8c175311983b634b426b8dd7948d67e75 merge bitcoin#24665: document clang tidy named args (Kittywhiskers Van Gogh)\n40a22e457afe525491132c990663f2c5e614616b merge bitcoin#24201: Avoid InitError when downgrading peers.dat (Kittywhiskers Van Gogh)\ncdcaf2278c7fb091457849ba692bbb0fb432c5a9 merge bitcoin#23373: Parse command line arguments from unit and fuzz tests, make addrman consistency check ratio easier to change (Kittywhiskers Van Gogh)\nb30f0fa4417ccb29314551ca74f660eb61206f25 test: remove `connman` local from `BasicTestingSetup` (Kittywhiskers Van Gogh)\ndf4356546446fa4b1704adb837bd4d421be5977d merge bitcoin#23826: Make AddrMan unit tests use public interface, extend coverage (Kittywhiskers Van Gogh)\nc14a54089fdbb73dab0bae9de4b2c3c86e27e4b3 merge bitcoin#23780: update `addrman_tests.cpp` to use output from `AddrMan::Good()` (Kittywhiskers Van Gogh)\n8b2db6bce434c466d58a386ac0fcc4d8d15b13a0 merge bitcoin#23713: refactor addrman_tried_collisions test to directly check for collisions (Kittywhiskers Van Gogh)\n5b5dd39f4540f05f0397a33798754731c7ac5a0e merge bitcoin#23492: tidy up addrman unit tests (Kittywhiskers Van Gogh)\naba0ebd40017b5dbad59a43a1b1462b8201be31b merge bitcoin#23477: tidy up unit tests (Kittywhiskers Van Gogh)\ncdc8321c4d3931164c1fa33b20c860c40851217b merge bitcoin#22872: improve checkaddrman logging with duration in milliseconds (Kittywhiskers Van Gogh)\n8d22fe9945bf31679b0ec8587285ff2cc7033e91 merge bitcoin#23084: avoid non-determinism in asmap-addrman test (Kittywhiskers Van Gogh)\nba4696718eb3913bdab814d789b98d6c7f6e1f10 partial bitcoin#23025: update nanobench add `-min_time` (Kittywhiskers Van Gogh)\nc28b05c5ca1d2b85687fa5e481e32208e7d48adc merge bitcoin#22831: add addpeeraddress \"tried\", test addrman checks on restart with asmap (Kittywhiskers Van Gogh)\nc4fe6085c86de50c24838fcecc688453e722ddc3 merge bitcoin#22226: add unittest core dump instructions (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * In [bitcoin#22831](https://github.com/bitcoin/bitcoin/pull/22831), when restarting the node in `rpc_net.py`'s `test_addpeeraddress()`, existing commands need to be appended to `extra_args` to ensure they're retained when the node is restarted (default behavior is to overwrite the argument list with `extra_args`) to prevent the test from hanging and then failing due to missing fast DIP3 activation params from the arguments list.\n\n Missing arguments result in a block database sanity check failure on restart due to `bad-qc-premature` arising from the activation height being higher than the height of a block with a quorum commitment.\n\n * `NodeContext` was moved from `TestingSetup` to `BasicTestingSetup` in [bitcoin#18571](https://github.com/bitcoin/bitcoin/pull/18571) ([dash#4844](https://github.com/dashpay/dash/pull/4844)) but `connman` as a `BasicTestingSetup` variable still stuck around (despite `NodeContext`'s presence making this unnecessary).\n\n To prepare for [bitcoin#22910](https://github.com/bitcoin/bitcoin/pull/22910), the remnant variable has been replaced with `m_node.connman` and adjustments have been made to that effect.\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK f0321194564bb50a71aafd48c04d0db262efdaaa\n PastaPastaPasta:\n utACK f0321194564bb50a71aafd48c04d0db262efdaaa\n\nTree-SHA512: b29c292ecda54cda8301ea804b433f80476a1cdbb72bd48740cc9b2e885a4ff52350e5e42f112426856282bd6d961f0e37f1b23020c52f07238413070bbc504a","shortMessageHtmlLink":"Merge #6243: backport: merge bitcoin#22226, bitcoin#22831, bitcoin#23084"}},{"before":"b1fadfb14f5a556e0702058a48e82bbdf88d53a0","after":"ddc53d7afd0ce6e3e3f3e996196845378ada3e8c","ref":"refs/heads/develop","pushedAt":"2024-09-04T17:11:27.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6067: backport: merge bitcoin#21148, #21327, #23970, #24021, #24543, #26844, #25325, #28165, partial bitcoin#20524, #26036, #27981 (networking backports: part 7)\n\n76a458e5f947e92376ecef17f2b1eef084247701 fmt: apply formatting suggestions from `clang-format-diff.py` (Kittywhiskers Van Gogh)\n63962ec47564be50485cc6398d20e9327ad508b7 merge bitcoin#28165: transport abstraction (Kittywhiskers Van Gogh)\nc6b9186e69299be34f520caf6f708fdee070acb6 merge bitcoin#25325: Add pool based memory resource (Kittywhiskers Van Gogh)\n8c986d6b08fd6218660a83e036f9002b388bf24f partial bitcoin#27981: Fix potential network stalling bug (Kittywhiskers Van Gogh)\n13f6dc1b27e914134d29accace3cd323e8c2a717 merge bitcoin#26844: Pass MSG_MORE flag when sending non-final network messages (Kittywhiskers Van Gogh)\ncaaa0fda01c224790c60d2d81fa1b18a7d262e6e net: use `std::deque` for `vSendMsg` instead of `std::list` (Kittywhiskers Van Gogh)\n2ecba6ba5fdb1798ba2cd23d38c8331269b71afe partial bitcoin#26036: add NetEventsInterface::g_msgproc_mutex (Kittywhiskers Van Gogh)\nf6c943922fd77d81756cf3d846ce6f92b301763c merge bitcoin#24543: Move remaining globals into PeerManagerImpl (Kittywhiskers Van Gogh)\ndbe41ea1417ef832e4df2bebc2ece70fa4b91060 refactor: move object request logic to `PeerManagerImpl` (Kittywhiskers Van Gogh)\n112c4e0a16c9781ac23f4ee86b105ce6daa11a9f merge bitcoin#24021: Rename and move PoissonNextSend functions (Kittywhiskers Van Gogh)\n6d690ede82d71381c6ac3dcb738824ba372b8552 merge bitcoin#23970: Remove pointless and confusing shift in RelayAddress (Kittywhiskers Van Gogh)\n87205f26b59a5ffd3940a339780c6084e47affb0 merge bitcoin#21327: ignore transactions while in IBD (Kittywhiskers Van Gogh)\n51ad8e4ddec40bb205584f8fdd033e3df2686503 merge bitcoin#21148: Split orphan handling from net_processing into txorphanage (Kittywhiskers Van Gogh)\ncbff29a6306a34148d69731ed9e71a5dd3e69c90 partial bitcoin#20524: Move MIN_VERSION_SUPPORTED to p2p.py (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * Dependent on https://github.com/dashpay/dash/pull/6098\n\n * Dependent on https://github.com/dashpay/dash/pull/6233\n\n * `p2p_ibd_txrelay.py` was first introduced in [bitcoin#19423](https://github.com/bitcoin/bitcoin/pull/19423) to test feefilter logic but on account of Dash not having feefilter capabilities, that backport was skipped over but on account of the tests introduced in [bitcoin#21327](https://github.com/bitcoin/bitcoin/pull/21327) that test capabilities present in Dash, a minimal version of `p2p_ibd_txrelay.py` has been committed in.\n\n * `vSendMsg` is originally a `std::deque` and as an optimization, was changed to a `std::list` in 027a852a ([dash#3398](https://github.com/dashpay/dash/pull/3398)) but this renders us unable to backport [bitcoin#26844](https://github.com/bitcoin/bitcoin/pull/26844) as it introduces build failures. The optimization has been reverted to make way for the backport.\n\n \n\n Compile failure:
\n\n ```\n net.cpp:959:20: error: invalid operands to binary expression ('iterator' (aka '_List_iterator>>') and 'int')\n if (it + 1 != node.vSendMsg.end()) {\n ~~ ^ ~\n /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/stl_bvector.h:303:3: note: candidate function not viable: no known conversion from 'iterator' (aka '_List_iterator>>') to 'ptrdiff_t' (aka 'long') for 1st argument\n operator+(ptrdiff_t __n, const _Bit_iterator& __x)\n [...]\n 1 error generated.\n make[2]: *** [Makefile:11296: libbitcoin_server_a-net.o] Error 1\n make[2]: *** Waiting for unfinished jobs....\n make[2]: Leaving directory '/src/dash/src'\n make[1]: *** [Makefile:19171: all-recursive] Error 1\n make[1]: Leaving directory '/src/dash/src'\n make: *** [Makefile:799: all-recursive] Error 1\n ```\n\n \n\n * The collection of `CNode` pointers in `CConnman::SocketHandlerConnected` has been changed to a `std::set` to allow for us to erase elements from `vReceivableNodes` if the node is _also_ in the set of sendable nodes and the send hasn't entirely succeeded to avoid a deadlock (i.e. backport [bitcoin#27981](https://github.com/bitcoin/bitcoin/pull/27981))\n\n * When backporting [bitcoin#28165](https://github.com/bitcoin/bitcoin/pull/28165), `denialofservice_tests` has been modified to still check with `vSendMsg` instead of `Transport::GetBytesToSend()` as changes in networking code to support LT-SEMs (level-triggered socket events mode) mean that the message doesn't get shifted from `vSendMsg` to `m_message_to_send`, as the test expects.\n * Specifically, the changes made for LT-SEM support result in the function responsible for making that shift (`Transport::SetMessageToSend()` through `CConnman::SocketSendData()`), not being called during the test runtime.\n\n * As checking `vSendMsg` (directly or through `nSendMsgSize`) isn't enough to determine if the queue is empty, we now also check with `to_send` from `Transport::GetBytesToSend()` to help us make that determination. This mirrors the change present in the upstream backport ([source](https://github.com/bitcoin/bitcoin/pull/28165/files#diff-00021eed586a482abdb09d6cdada1d90115abe988a91421851960e26658bed02R1324-R1327)).\n\n ## Breaking Changes\n\n * `bandwidth.message.*.bytesSent` will no longer include overhead and will now only report message size as specifics that let us calculate the overhead have been abstracted away.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 76a458e5f947e92376ecef17f2b1eef084247701\n\nTree-SHA512: 2e47c207c1f854cfbd5b28c07dd78e12765ddb919abcd7710325df5d253cd0ba4bc30aa21545d88519e8acfe65638a57db4ca66853aca82fc355542210f4b394","shortMessageHtmlLink":"Merge #6067: backport: merge bitcoin#21148, bitcoin#21327, bitcoin#23970"}},{"before":"a83f76b0d52d138778edee94777beb16b2552eae","after":"b1fadfb14f5a556e0702058a48e82bbdf88d53a0","ref":"refs/heads/develop","pushedAt":"2024-09-04T16:26:41.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6242: refactor: add a new flag disable_mocktime to set_test_params()\n\nef4d74a669bce1d59a54f72b2ee9b593745b8ba5 test: remove dead code from `p2p_initial_headers_sync.py` to favor of disable mocktime (UdjinM6)\n4d9837c21e0ee95c2f500e1b4a02d4333e3e17e8 refactor: add a new flag disable_mocktime to set_test_params() (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n To disable mocktime you should re-implement setup_nodes(). It seems as bug-friendly solution\n\n ## What was done?\n This PR introduce a new flag \"disable_mocktime\" which can be set in `set_test_params`.\n It seems more error prune and the code is shorter\n\n ## How Has This Been Tested?\n Run unit/functional tests including future changes from https://github.com/dashpay/dash/pull/6235\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK ef4d74a669bce1d59a54f72b2ee9b593745b8ba5\n kwvg:\n utACK ef4d74a669bce1d59a54f72b2ee9b593745b8ba5\n PastaPastaPasta:\n utACK ef4d74a669bce1d59a54f72b2ee9b593745b8ba5\n\nTree-SHA512: c6be8002cae4d7824e150938957464c156931d0b6f7fc41c430a83d662865431f1b56cb11df73f56db54a140f36b0addd68b2917e25c5c941fae52e8d322bc25","shortMessageHtmlLink":"Merge #6242: refactor: add a new flag disable_mocktime to set_test_pa…"}},{"before":"381c59a674fa72a5826fa5faf9944ecbc2af7dcd","after":"a83f76b0d52d138778edee94777beb16b2552eae","ref":"refs/heads/develop","pushedAt":"2024-09-03T14:27:28.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6234: backport: bitcoin#21178, #22089, #22130, #22210, #22216, bitcoin-core/gui#361, partial: bitcoin#14123\n\nbe5c84f41d70ceed1fab4e92f62318c67c1b1ead Merge bitcoin/bitcoin#22089: test: MiniWallet: fix fee calculation for P2PK and check tx vsize (MarcoFalke)\n247141d32ca5296af4c0fa5bc6b43eff20fcb99e Merge bitcoin/bitcoin#22210: test: Use MiniWallet in test_no_inherited_signaling RBF test (MarcoFalke)\ndad3ae3f33d971290bc7cf485d6c7bdec118d3a2 Merge bitcoin/bitcoin#22130: test: refactor: dedup utility function chain_transaction() (MarcoFalke)\n9dff334f474b6ada71804ecfef0e05376dff336a Merge bitcoin-core/gui#361: Fix gui segfault caused by bitcoin/bitcoin#22216 (Hennadii Stepanov)\n10878499554934dc4b67f2dd6053f13bd78f2985 Merge bitcoin/bitcoin#22216: refactor: Make SetupServerArgs callable without NodeContext (MarcoFalke)\nfd94de6888cd878dbd7383c7430be52a705fe496 Merge bitcoin/bitcoin#21178: test: run mempool_reorg.py even with wallet disabled (MarcoFalke)\nf1f5723fcf99f70acd3c4864d9139572dc716fed fix: missing changes from bitcoin#14123 (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Regular backports from bitcoin v22\n\n ## What was done?\n See commits for list of backported changes. It also have some missing changes from bitcoin#14123\n\n ## How Has This Been Tested?\n Run unit/functional tests\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK be5c84f41d70ceed1fab4e92f62318c67c1b1ead\n PastaPastaPasta:\n utACK https://github.com/dashpay/dash/commit/be5c84f41d70ceed1fab4e92f62318c67c1b1ead\n\nTree-SHA512: 553ffde63c8409799cf6b3b87bf1ee285fbf58b13c08d04cdac29bc0e4dd75059feaa2f163803084ae85175397512517b68a6e0e0cc602d981f38ac70d96e393","shortMessageHtmlLink":"Merge #6234: backport: bitcoin#21178, bitcoin#22089, bitcoin#22130, b…"}},{"before":"0472a07f1a4230fd49748cbe45349a9582bc0d04","after":"381c59a674fa72a5826fa5faf9944ecbc2af7dcd","ref":"refs/heads/develop","pushedAt":"2024-09-03T14:19:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6241: chore: bump version on develop to 21.2\n\nf5b29e3227d7f5911e94886b13b95155d8caf4ae chore: bump version on develop to 21.2 (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Currently, builds such as nightlies still think they are 21.1, but they're not. Bump it to 21.2. We should be continually updating this in develop to reflect what we expect next version to be\n\n ## What was done?\n\n ## How Has This Been Tested?\n\n ## Breaking Changes\n None\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n kwvg:\n utACK f5b29e3227d7f5911e94886b13b95155d8caf4ae\n UdjinM6:\n utACK f5b29e3227d7f5911e94886b13b95155d8caf4ae\n\nTree-SHA512: 4bd6d51a247f7c889284da94a4c80c4de43787d8dae62c5b24ad41addadb599e4921149e74b93533d4353c31e9c8ef01cbfc8ec3060f0aded4132703a1cf8412","shortMessageHtmlLink":"Merge #6241: chore: bump version on develop to 21.2"}},{"before":"7a9e475c26c54687f3638c0a45d289470e3f2ef9","after":"0472a07f1a4230fd49748cbe45349a9582bc0d04","ref":"refs/heads/develop","pushedAt":"2024-09-03T13:45:30.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6061: backport: Merge bitcoin#(partial) 24355, 24797\n\ne5e0b00e1e6909054137ef6656df743c82010ed3 Merge bitcoin/bitcoin#24797: test: compare `/chaininfo` response with `getblockchaininfo` RPC (MarcoFalke)\n39bca402a07c1875d104325846ec8292134d31f0 (partial) Merge bitcoin/bitcoin#24355: util, refactor: Add UNIQUE_NAME helper macro (laanwj)\n\nPull request description:\n\n bitcoin backports\n\nACKs for top commit:\n PastaPastaPasta:\n utACK e5e0b00e1e6909054137ef6656df743c82010ed3\n\nTree-SHA512: 82d68090935b47b63c1f09ffcc660277b3054e60b96b455fb81dfd4b6180ec272df943bd4c1691a2cdbc76da668f362cd42653fa67a8fd2d44197ab316bbd36f","shortMessageHtmlLink":"Merge #6061: backport: Merge bitcoin#(partial) 24355, 24797"}},{"before":"630254e00cd62c06139d06afa0cd5c910f4ab40c","after":"7a9e475c26c54687f3638c0a45d289470e3f2ef9","ref":"refs/heads/develop","pushedAt":"2024-08-31T03:19:32.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6231: backport: merge bitcoin#19572, #20953, #20523, #21008, #21310, #22079, #23471, #24218 (zmq backports)\n\nb75e83b298377f59e242479fc243a457ff04c2e0 merge bitcoin#24218: Fix implicit-integer-sign-change (Kittywhiskers Van Gogh)\n8ecc22f51f456eb9c9eef6712333bc20726ac4bf merge bitcoin#23471: Improve ZMQ documentation (Kittywhiskers Van Gogh)\n2965093c4aabef46b61f9eda5498ed544845ba9e merge bitcoin#22079: Add support to listen on IPv6 addresses (Kittywhiskers Van Gogh)\n3ac37149576d90a2d6bbfc177d706b78171f82db merge bitcoin#21310: fix sync-up by matching notification to generated block (Kittywhiskers Van Gogh)\n7b0c725c594f9f0ee85c02dc20bd8adce7d9ac85 merge bitcoin#21008: fix zmq test flakiness, improve speed (Kittywhiskers Van Gogh)\n5e87efd04b06f71613bbf886691b4e81d2b734a7 merge bitcoin#20523: deduplicate 'sequence' publisher message creation/sending (Kittywhiskers Van Gogh)\n99c730f0f33074dcb7163b3e5a3938ff26fc4104 merge bitcoin#20953: dedup zmq test setup code (node restart, topics subscription) (Kittywhiskers Van Gogh)\n982c1f03d4b7192db2cb9a379b49ed82dc22a5c7 merge bitcoin#19572: Create \"sequence\" notifier, enabling client-side mempool tracking (Kittywhiskers Van Gogh)\nb0b4e0fa7f12e2135b3a2d0310b9ee4a37782f57 zmq: Make `g_zmq_notification_interface` a smart pointer (Kittywhiskers Van Gogh)\n0a1ffd30b9a070afe8c5d584acc74a601304e330 zmq: extend appending address to log msg for Dash-specific notifications (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * [bitcoin#19572](https://github.com/bitcoin/bitcoin/pull/19572) introduces tests in `interface_zmq.py` that validate newly introduced \"sequence\" reporting of all message types (`C`, `D`, `R` and `A`). The `R` message type (removed from mempool) is tested by leveraging the RBF mechanism, which isn't present in Dash.\n\n In order to allow the tests to successfully pass, all fee bumping and RBF-specific code had to be removed from the tests. This test also involves creating a new block to test the `C` message (connected block) that would return a `time-too-new` error and fail unless mocktime has been disabled (which has been done in this test).\n\n * When backporting [bitcoin#18309](https://github.com/bitcoin/bitcoin/pull/18309) ([dash#5728](https://github.com/dashpay/dash/pull/5728)), Dash-specific ZMQ notifications did not have those changes applied to them and that particular backport was merged upstream *after* [bitcoin#19572](https://github.com/bitcoin/bitcoin/pull/19572), meaning, for completion, the changes from [bitcoin#18309](https://github.com/bitcoin/bitcoin/pull/18309) have been integrated into [bitcoin#19572](https://github.com/bitcoin/bitcoin/pull/19572)'s backport.\n\n As for the Dash-specific notifications, they have been covered to ensure uniformity in a separate commit.\n\n * The ZMQ notification interface has been converted to a smart pointer in the interest of safety (this change is eventually done upstream in 8ed4ff8e05d61a8e954d72cebdc2e1d1ab24fb84 ([bitcoin#27125](https://github.com/bitcoin/bitcoin/pull/27125)))\n\n ## Breaking Changes\n\n None expected.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK b75e83b298377f59e242479fc243a457ff04c2e0\n PastaPastaPasta:\n utACK b75e83b298377f59e242479fc243a457ff04c2e0\n knst:\n utACK b75e83b298377f59e242479fc243a457ff04c2e0\n\nTree-SHA512: 9f860d1203bebe0914a5102f101f646873d14754830d651fb91ed0d1285a6c1a58ffc492b07d4768324d94f53171c9a4da974cf4a0b1e5c665979eace289f6f0","shortMessageHtmlLink":"Merge #6231: backport: merge bitcoin#19572, bitcoin#20953, bitcoin#20523"}},{"before":"d16e95352ca1a3e0596627e61efed426531d43c5","after":"630254e00cd62c06139d06afa0cd5c910f4ab40c","ref":"refs/heads/develop","pushedAt":"2024-08-31T03:13:12.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6238: refactor: drop some unneeded `this` and `const`\n\n5aefd44ea38503a79f962bf138dff6b9049f2f9c fmt: run clang-format (pasta)\n7e9dec290f970467c1426b3302fa3cfbe6126e8c refactor: drop some unneeded `this` and `const` (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Neither identifies are used for anything, the const is always gonna be discarded as it's on a value return value, and the `this` is not used, so should be dropped.\n\n This fixes some spammy warnings for me locally\n\n ## What was done?\n\n ## How Has This Been Tested?\n Compiled in CI\n\n ## Breaking Changes\n None\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 5aefd44ea38503a79f962bf138dff6b9049f2f9c\n UdjinM6:\n utACK 5aefd44ea38503a79f962bf138dff6b9049f2f9c\n\nTree-SHA512: 9ebfae9bccc8893dc79c25d2b824680f63d27ab2da82089c96660eacb5891577e00145f6b70a20b161fc6fda1b6e5cfd6897502ffd356f8febcec76844623613","shortMessageHtmlLink":"Merge #6238: refactor: drop some unneeded this and const"}},{"before":"cddbc2a87b738cf752868e3cd42f38b94f27f58e","after":"d16e95352ca1a3e0596627e61efed426531d43c5","ref":"refs/heads/develop","pushedAt":"2024-08-31T03:08:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6233: fix: release unused memory in `CNetMsgMaker::Make()`\n\nc2c4b2b7948f8d4a63ad2bcdda8ffad584fb9cf6 fix: release unused memory in `CNetMsgMaker::Make()` (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n We reserve capacity for large messages in `CNetMsgMaker::Make()` but most messages are small yet we never release unused memory here. Discovered while debugging 28165 backport issues.\n\n ## What was done?\n\n ## How Has This Been Tested?\n\n ## Breaking Changes\n n/a\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone\n\nACKs for top commit:\n kwvg:\n ACK c2c4b2b7948f8d4a63ad2bcdda8ffad584fb9cf6\n PastaPastaPasta:\n utACK c2c4b2b7948f8d4a63ad2bcdda8ffad584fb9cf6\n knst:\n utACK c2c4b2b7948f8d4a63ad2bcdda8ffad584fb9cf6\n\nTree-SHA512: 72a3728e316fb76ca135fbfff4f15b80c60b048d7e916d2f5dbcde4b64dce7177af80f8f24153636ccfab2f5d5c7d9edc5b3bdba121f64c8da03117a98fd7411","shortMessageHtmlLink":"Merge #6233: fix: release unused memory in CNetMsgMaker::Make()"}},{"before":"e3a5afd6a605356162f22a3aaf1e76535d46339e","after":"cddbc2a87b738cf752868e3cd42f38b94f27f58e","ref":"refs/heads/develop","pushedAt":"2024-08-30T15:32:25.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6240: backport: partial bitcoin#27920, #28799, #29007 - to improve CI experience\n\n2eadcf2f680928dda61cddefa32600226e9238a9 partial Merge bitcoin/bitcoin#29007: test: create deterministic addrman in the functional tests (stratospher)\nf95ca4ed3e573d6d6bc912f42927e0d2cafafb8d fix: unify with bitcoin: removed requirement of txindex=0 (Konstantin Akimov)\nbf46e7a8e1ded06fc94f9edfafbfb5b125bc51e8 partial Merge bitcoin/bitcoin#28799: wallet: cache descriptor ID to avoid repeated descriptor string creation (Andrew Chow)\n05e596619902a588372c414ea3bff6167da4c73b partial Merge bitcoin/bitcoin#27920: wallet: bugfix, always use apostrophe for spkm descriptor ID (furszy)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Lately our CI for tsan is flapping many functional tests and take long times.\n\n This PR has several important changes backported from the latest bitcoin's version to improve CI experience\n\n ## What was done?\n This PR has several backports that improved CI experience drastically.\n\n **Firstly, it aims to fix flapping test p2p_node_network_limited.py**\n\n For example: https://gitlab.com/dashpay/dash/-/jobs/7692635307\n\n \n\n p2p_node_network_limited.py | ✖ Failed | 28 s
\n\n ```\n test 2024-08-29T02:50:53.929000Z TestFramework (ERROR): Assertion failed\n Traceback (most recent call last):\n File \"/builds/dashpay/dash/build-ci/dashcore-linux64_tsan/test/functional/test_framework/test_framework.py\", line 158, in main\n self.run_test()\n File \"/builds/dashpay/dash/build-ci/dashcore-linux64_tsan/test/functional/p2p_node_network_limited.py\", line 79, in run_test\n self.nodes[0].disconnect_p2ps()\n File \"/builds/dashpay/dash/build-ci/dashcore-linux64_tsan/test/functional/test_framework/test_node.py\", line 611, in disconnect_p2ps\n wait_until_helper(check_peers, timeout=5)\n File \"/builds/dashpay/dash/build-ci/dashcore-linux64_tsan/test/functional/test_framework/util.py\", line 262, in wait_until_helper\n raise AssertionError(\"Predicate {} not true after {} seconds\".format(predicate_source, timeout))\n AssertionError: Predicate ''''\n def check_peers():\n for p in self.getpeerinfo():\n for p2p in self.p2ps:\n if p['subver'] == p2p.strSubVer:\n return False\n return True\n ''' not true after 5.0 seconds\n ```\n \n\n **Secondly, it improves performance of Descriptor wallets significantly for case of `tsan` CI**. It is tiny improvement for Release build and local runs, but some fucnctional tests run as fast as twice:\n\n https://gitlab.com/dashpay/dash/-/jobs/7694458953\n https://gitlab.com/dashpay/dash/-/jobs/7665132625\n\n ```\n wallet_create_tx.py --descriptors | ✓ Passed | 236 s <-- new version\n wallet_create_tx.py --legacy-wallet | ✓ Passed | 108 s\n wallet_basic.py --descriptors | ✓ Passed | 135 s <---- new version\n wallet_basic.py --legacy-wallet | ✓ Passed | 97 s\n\n wallet_create_tx.py --descriptors | ✓ Passed | 456 s <-- old version\n wallet_create_tx.py --legacy-wallet | ✓ Passed | 98 s\n wallet_basic.py --descriptors | ✓ Passed | 189 s <--- old version\n wallet_basic.py --legacy-wallet | ✓ Passed | 131 s\n ```\n See performance investigation here: https://github.com/dashpay/dash/pull/6226\n\n ## How Has This Been Tested?\n Run unit/functional tests\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 2eadcf2f680928dda61cddefa32600226e9238a9\n UdjinM6:\n utACK 2eadcf2f680928dda61cddefa32600226e9238a9\n\nTree-SHA512: 127fbaa65c160aa95e2145a6b40d3811f7c42e36fbee9ce98a9ac021abd9cbe6edc7791870b331a54855ba891e3804885db7936ef212647b693f50f79a60d232","shortMessageHtmlLink":"Merge #6240: backport: partial bitcoin#27920, bitcoin#28799, bitcoin#…"}},{"before":"8d3f31306eba61770ab4fee6caf3ecb569ecdb49","after":"e3a5afd6a605356162f22a3aaf1e76535d46339e","ref":"refs/heads/develop","pushedAt":"2024-08-29T17:44:56.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6064: backport: Merge bitcoin#22568, 21800, (partial)22707\n\nbda74458b577c71a2f1b3279be2110ed67413052 (partial) Merge bitcoin/bitcoin#22707: test: refactor use of getrawmempool in functional tests for efficiency (MarcoFalke)\n1a8268770c2b8a0bfbacd3e7749fd208932afbc8 Merge bitcoin/bitcoin#21800: mempool/validation: mempool ancestor/descendant limits for packages (fanquake)\n97fd2b2842d6448a91963e4dcb84ff6d0c59c74d Merge bitcoin/bitcoin#22568: test: add addr-fetch peer connection state and timeout coverage (MarcoFalke)\n\nPull request description:\n\n bitcoin backports\n\nACKs for top commit:\n UdjinM6:\n utACK bda74458b577c71a2f1b3279be2110ed67413052\n PastaPastaPasta:\n utACK bda74458b577c71a2f1b3279be2110ed67413052\n\nTree-SHA512: a001f790b36df8e6c640c383a302ce47a6add63f39561596a670fd8261b9a461d71b31b6457a78706a2f596134705879f5f4ba142a79ee587eba02302f57be71","shortMessageHtmlLink":"Merge #6064: backport: Merge bitcoin#22568, 21800, (partial)22707"}},{"before":"a40802b1fc83716dbce089915fc2847534b25394","after":"8d3f31306eba61770ab4fee6caf3ecb569ecdb49","ref":"refs/heads/develop","pushedAt":"2024-08-29T00:31:59.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6039: fix: optimize compilation time of gsl library\n\ndc59cbc3155a0d4e0091d58b373c3e9dae740760 fix: optimize includes in gsl/pointer.h to speed up compile time (Konstantin Akimov)\nd5e32e1b7965f70acc9a708f5d8d0158cd1b2558 fix: disable gsl iostream feature for faster compile time (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n This header `gsl/pointers.h` is included in multiple other headers all over codebase.\n Any extra line of code inside gsl/pointers.h makes all project to compile slower.\n\n ## What was done?\n Removed headers ``, ``, `` from gsl/pointers.h\n\n ## How Has This Been Tested?\n Run command 5 times, takes minimum time:\n\n - baseline\n ```\n $ time g++ -o /tmp/a.out gsl/pointers.h -O2 -g -I.\n real 0m0,572s\n user 0m0,461s\n sys 0m0,108s\n ```\n\n - removed algorithm:\n ```\n $ time g++ -o /tmp/a.out gsl/pointers.h -O2 -g -I.\n real 0m0,505s\n user 0m0,398s\n sys 0m0,107s\n ```\n\n - removed algorithm and system_error:\n ```\n real 0m0,332s\n user 0m0,265s\n sys 0m0,067s\n ```\n\n - disabled iostream:\n ```\n $ time g++ -o /tmp/a.out gsl/pointers.h -O2 -g -I. -D GSL_NO_IOSTREAMS\n real 0m0,316s\n user 0m0,256s\n sys 0m0,060s\n ```\n\n as a result, overall project compilation time is also improved: `make clean ; sleep 3s ; time make -j20`\n ```\n real 5m42,934s\n user 80m35,127s\n sys 6m40,735s\n ```\n ```\n real 5m28,862s\n user 75m31,931s\n sys 6m32,591s\n ```\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK dc59cbc3155a0d4e0091d58b373c3e9dae740760\n\nTree-SHA512: 353d79c0e297c92e823972b53daaaed42494554ce550ea800ce8aa6990c704cedfbcb922e1d735eb8fc01ad14ffa873d86cdbc4d3731d841496392bb74286d33","shortMessageHtmlLink":"Merge #6039: fix: optimize compilation time of gsl library"}},{"before":"6dbed2ae75919309172add03873feceaf6070e25","after":"a40802b1fc83716dbce089915fc2847534b25394","ref":"refs/heads/develop","pushedAt":"2024-08-29T00:29:39.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6156: fix: let internal govobj/vote inv request trackers expire after 60 sec\n\n1f4e1a17edf728f03ef9942e219e354b16ba43de test: add test for governance inv expiration (UdjinM6)\n06b4dba0d36a2f8d62390737f4ee5703cad30547 feat: make CInv python implementation aware of governance invs (UdjinM6)\nc7c930ece6c15474f939483015634c03653249aa fix: use correct condition in logs (UdjinM6)\nd41d87a5be947fdd980c9fb72613f7f7e440662e fix: use `std::chrono::seconds` (UdjinM6)\nd6fe7146ff9525793def61487404630e9622e828 chore: make clang-format and linter happy (UdjinM6)\nb57a9220c1e7495177d675c1b6d08ce817cf6c4e refactor: sqash 2 hash maps into one, use proper naming (UdjinM6)\n4116ba3253c028559bcc5007f8fc6afe967b7c3e fix: let internal govobj/vote inv request trackers expire after 60 sec (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Another issue noticed during recent sb voting period. Lots of inv are coming from peers that never send the object/vote they announced. Let's not wait for these forever, 60 seconds should be enough.\n\n ## What was done?\n Add a \"timer\" to each request.\n\n ## How Has This Been Tested?\n Run tests, run a MN on mainnet and check logs.\n\n ## Breaking Changes\n n/a\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 1f4e1a17edf728f03ef9942e219e354b16ba43de\n\nTree-SHA512: f5c5a896f61b5aed27c6f42c926254156c604edb4efd2a3cd3738a7e8d1ed7bafffadc584148e4a5c1a172c2b3d61a06884a1f6d56eb4ebe37a4b0dbc050edd6","shortMessageHtmlLink":"Merge #6156: fix: let internal govobj/vote inv request trackers expir…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEue4uJAA","startCursor":null,"endCursor":null}},"title":"Activity · dashpay/dash"}