Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code actions with out null-ls #23

Closed
sajadspeed opened this issue Oct 27, 2023 · 8 comments
Closed

Code actions with out null-ls #23

sajadspeed opened this issue Oct 27, 2023 · 8 comments

Comments

@sajadspeed
Copy link

Hi, How can i use code actions with out null-ls?
I use cmp and nvim-lint for compilation and linting.

@davidmh
Copy link
Owner

davidmh commented Oct 30, 2023

Unfortunately, that's not possible at the moment. The code actions use null-ls as the LSP client, without it, we would have to come up with a stand alone client.

I know there are a few options out there to build generic language servers, but I haven't had the time to look into it.

@davidmh davidmh closed this as completed Oct 30, 2023
@sajadspeed
Copy link
Author

I found this one repository from you:
cspell-nvim-minimal-init
Does this not solve my problem? I want to have both code actions and diagnostics without null-ls.

@davidmh
Copy link
Owner

davidmh commented Dec 26, 2023

No, you can see I'm installing null-ls here: https://github.com/davidmh/cspell-nvim-minimal-init/blob/main/minimal-init.lua#L33-L48

@sajadspeed
Copy link
Author

OK. Thanks a lot.

@quolpr
Copy link

quolpr commented Jun 26, 2024

I was able to make cspell-ls working on nvim, but the code looks somehow hacky + you need to modify extension and build locally

neovim/nvim-lspconfig#1056 (comment)

But the great thing about that - you will not depend on none-ls + performance much better

@davidmh
Copy link
Owner

davidmh commented Jun 26, 2024

That's great @quolpr, do you think your changes to vscode-spell-checker can be upstreamed into the original repository?

I would definitely deprecate this plugin if we had a standalone LSP.

@quolpr
Copy link

quolpr commented Jun 27, 2024

Hey @davidmh!

I opened issue here streetsidesoftware/vscode-spell-checker#3406 . I think cspell need native mode support, to avoid all hacks that I did. Let's see how discussion will go 🙂

@quolpr
Copy link

quolpr commented Jun 28, 2024

Finally! I was able to make lsp config without modifying cspell. Here is gist with instruction https://gist.github.com/quolpr/2d9560c0ad5e77796a068061c8ea439c

But still thinking about to add native mode to vscode-spell-checker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants