Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Server error-ing during daytona serve doesn't stop the process #1722

Open
idagelic opened this issue Jan 15, 2025 · 0 comments
Open

API Server error-ing during daytona serve doesn't stop the process #1722

idagelic opened this issue Jan 15, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@idagelic
Copy link
Member

Describe the bug
If the API Server errors (e.g. returning an err on demand in apiServer.Start() on demand) when running daytona serve, the serve process doesn't exit for ~30 seconds until the "waiting" for API server to start function finishes.

Expected behavior
The "waiting" for API server function before printing the "You may start developing with Daytona" box should be run asynchronously, allowing the select call that listens to error channels the correctly detect any errors

@idagelic idagelic added the bug Something isn't working label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant