Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup doesn't respect user provided database information #17

Open
cullenlinn opened this issue Mar 16, 2016 · 0 comments
Open

Setup doesn't respect user provided database information #17

cullenlinn opened this issue Mar 16, 2016 · 0 comments

Comments

@cullenlinn
Copy link

During the last commit when the DashboardController and DashboardModel were refactored for DI, the logic to merge the post input with the config was lost and now only the json config database information is respected.

This can be reproduced by doing a net new installation of the app and supplying custom database information.

One fix is to perform the config and input merging in the controller's updateDatabase method. I confirmed that this approach corrects the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant