Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing data difference between dataset building and AtomicData.from_points/from_ase/... #149

Open
floatingCatty opened this issue Apr 28, 2024 · 0 comments

Comments

@floatingCatty
Copy link
Member

Background

The user often uses the latter api to perform calculations on jupyter notebook, however, it does not have some vital properties as the one gets from AtomicData built from dataset. Including:

  1. some initialized node/edge/overlap features
  2. SOC related features
  3. atom/bond type features that are mapped from idp.

This is very hurtful since the user tends not to know where the AtomicData are getting from,causing troubles for our daily usage.

Describe the solution you'd like

Figure out a way to optimizing this, either by unify the process of getting atomic data class, or making the dependence on the parameters such as SOC and bond/atom type implicit.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant