Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite test for HSolver #5442

Open
9 tasks
Cstandardlib opened this issue Nov 8, 2024 · 1 comment
Open
9 tasks

Rewrite test for HSolver #5442

Cstandardlib opened this issue Nov 8, 2024 · 1 comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0

Comments

@Cstandardlib
Copy link
Collaborator

Describe the Testing Issue

We need clear unit tests for

  • HSolver iterative solvers, with a pure matrix and initial guess we can define and change easily.
  • Key operators like gemm, to ensure they work properly in different devices and libraries.
  • Current tests depend on Psi and Hamilt class and they are difficult to adjust to debug.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Understand the testing issue described by the developer.
  • Review the specific test case, expected and actual results, and any error messages.
  • Identify the root cause of the test failure or issue.
  • If a possible solution is suggested, evaluate its feasibility and effectiveness.
  • Implement a fix for the test failure or issue, or create a new test case if needed.
  • Verify that the fix resolves the testing issue and the test case passes.
  • Review and update any relevant documentation, such as test plans or user guides.
  • Ensure the testing issue is resolved and close the ticket.
  • Share any lessons learned or best practices with the team to prevent similar issues in the future.
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Nov 8, 2024
@Cstandardlib
Copy link
Collaborator Author

Now that HSolver_PW solvers take raw data (T *), while tests still depend on Hamilt and Psi custom types. They are unreadable and difficult to test and debug. We can update the tests to match the modified code interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

No branches or pull requests

2 participants