Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown partly rendered even though disabled, wrong link warning #4559

Open
r10s opened this issue Jan 25, 2025 · 2 comments
Open

markdown partly rendered even though disabled, wrong link warning #4559

r10s opened this issue Jan 25, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Jan 25, 2025

we do not want to render markdown at the moment -- it is still too experimental, it is not our current focus, and it is not supported on all platforms. having that partly supported weakens overall UX.

therefore, text should be rendered as entered.

however, for this is not aways true.

if one enters this is **bold**, *italic*, [link](https://delta.chat) one gets the following:

Screenshot 2025-01-25 at 14 06 44

the link is rendered as mark down, but should not.

this is not a new issue, i just came over that when noticing another issue (as said, it is experimental or reasons, similar to location streaming :) - the other issue is that the upcoming dialog shows weird punycode, though the link does not require punycode:

Screenshot 2025-01-25 at 14 10 52

at some point, we may focus on markdown, but that day is not today :)

tested on mac 1.50.1

@r10s r10s added the bug Something isn't working label Jan 25, 2025
@r10s
Copy link
Member Author

r10s commented Jan 25, 2025

hm, that seemed to be introduced unconditionally of the markdown switch at #1771. i find that a little bit questionable, these kind of things affecting the whole ecosystems should be regarded platform comprehensive. otoh, the expectation that time was also to go for message-parser rendering on all platforms soon, so a that time reasonable change.

but anyways, as it is now in since years, and getting rid of that may again introduce bugs, i am fine to leave link rendering as is, and only fix the punycode issue

@r10s r10s changed the title markdown partly rendered even though disabled markdown partly rendered even though disabled, wrong link warning Jan 25, 2025
@Simon-Laux
Copy link
Member

Simon-Laux commented Jan 27, 2025

you might mean this: deltachat/message-parser#88
does also affect normal links, not only labeled links.

Also adding labeled links was an intentional decision, there is explicitly a "desktop set" in the message parser (https://github.com/deltachat/message-parser/blob/master/spec.md#modes-of-the-parser) but the bug is not in labeled links only, it is more low-level as it seems to affects all links as stated above..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants