Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endianess return type #1

Closed
leonskij opened this issue Oct 17, 2021 · 3 comments
Closed

endianess return type #1

leonskij opened this issue Oct 17, 2021 · 3 comments

Comments

@leonskij
Copy link

The endianess function currently returns a boolean; wouldn't it be better to use an enum here so that it's more clear what is being returned?

I could make a quick PR for this if you'd like me to.

@eliassjogreen
Copy link
Member

The design decision that was made was to match the DataView endianess boolean where true is little endian mostly to conform and not stray away too far from the web standard api which we use under the hood.

@leonskij
Copy link
Author

Ah, coolio. I completely forgot that this issue even existed and what you said makes sense.

@eliassjogreen
Copy link
Member

Me too! Found it when I was looking through my issues on GitHub and saw I hadn't answered, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants