Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.lock on the PR'ed branch #14

Open
BusterNeece opened this issue May 13, 2017 · 1 comment
Open

Update composer.lock on the PR'ed branch #14

BusterNeece opened this issue May 13, 2017 · 1 comment
Labels

Comments

@BusterNeece
Copy link

BusterNeece commented May 13, 2017

My automated test suite in my CI toolkit only uses composer install as is recommended, so that it does not change the composer dependencies that will be used by end users installing the product. Even with an updated composer.json file, the test suite will still pass using the old composer.lock dependencies, which does not actually indicate whether or not the new dependencies will succeed.

@m1guelpf m1guelpf added the Ideas label May 14, 2017
@m1guelpf
Copy link
Member

@SlvrEagle23 Had a look at how Composer generates the lockfile, and it isn't currently possible to generate or modify it. Added a section on the PR body explaining this issue and how to fix it as a temporal solution.

@m1guelpf m1guelpf added Beta and removed Ideas labels May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants