Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ad width to the width of content #35

Open
dhowe opened this issue Dec 15, 2021 · 3 comments
Open

Limit ad width to the width of content #35

dhowe opened this issue Dec 15, 2021 · 3 comments
Assignees
Labels
priority: High question Further information is requested
Milestone

Comments

@dhowe
Copy link
Owner

dhowe commented Dec 15, 2021

No sure how possible this is, but very necessary.
If not, perhaps we just skip ads greater than half the page width

again, the goal here is to be subtle, not to disrupt the page flow or design

image

@dhowe dhowe added the question Further information is requested label Dec 15, 2021
@dhowe dhowe added this to the Version 2.0 milestone Dec 15, 2021
@Real-John-Cheung
Copy link
Collaborator

Different websites have different css setting to constrain their content, we will need to make specific solution for each of them...
I think the best option here is to set a width limit (for example, 1200px) and skip any ad that is bigger than that

@dhowe
Copy link
Owner Author

dhowe commented Jan 5, 2022

I think 800px is a good limit to start with

@Real-John-Cheung
Copy link
Collaborator

add width limit with 7052798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: High question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants