Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trac RSS links broken #204

Closed
medmunds opened this issue Jun 28, 2024 · 2 comments · Fixed by #206
Closed

Trac RSS links broken #204

medmunds opened this issue Jun 28, 2024 · 2 comments · Fixed by #206

Comments

@medmunds
Copy link

When you are already logged into Django's Trac, the RSS links go to a login page rather than the RSS feed, and there's no obvious way to actually get the RSS.

To reproduce:

  1. Log into Trac using a GitHub account. [I haven't tested with a Trac account.]
  2. Go to https://code.djangoproject.com/timeline or https://code.djangoproject.com/query (default or with any query options)
  3. Scroll to the bottom of the page and click the "RSS Feed" link

Results: you are redirected to the login page (despite already being logged in), with the query "referer" param set to the RSS feed url. But trying to login again there (with GitHub) sends you to the Trac homepage rather than the RSS feed (likely because of #195).

Expected: you should end up on the appropriate RSS feed

Note: these RSS feeds don't actually require login. Also, the "Comma-delimited Text" and "Tab-delimited Text" links at the bottom of the query page don't have this problem.

Workaround: either logout first (the links aren't broken when you're logged out), or ignore the RSS links and instead just append a format=rss query param to the query/timeline URL.

@bmispelon
Copy link
Member

Hi and thanks for the report, it's much appreciated.

I can indeed reproduce the behavior you're describing, and I agree that it doesn't work as it should.

These links are generated automatically by Trac, so I've had a dive in the source code 🤿 . It seems that Trac uses a special auth_link for some of the links, including the RSS ones. As you've correctly identified, this breaks because of #195 .

Unfortunately I don't see a way to work around Trac's behavior here (not without reimplementing a bunch of templates which is not maintainable), so the solution that remains is to fix #195 .

So I'm going to close this issue as a duplicate, but please reopen (or comment) if you have an idea for how to solve this specific issue independently of #195.

Have a nice day! ✨

@bmispelon bmispelon closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2024
bmispelon added a commit to bmispelon/code.djangoproject.com that referenced this issue Jun 29, 2024
@bmispelon
Copy link
Member

Of course after writing this comment I realized there was an easy workaround after all: #206

@bmispelon bmispelon reopened this Jun 29, 2024
bmispelon added a commit to bmispelon/code.djangoproject.com that referenced this issue Jun 29, 2024
bmispelon added a commit to bmispelon/code.djangoproject.com that referenced this issue Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants