Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a version support policy #20

Open
mjtamlyn opened this issue Mar 22, 2015 · 2 comments
Open

Decide on a version support policy #20

mjtamlyn opened this issue Mar 22, 2015 · 2 comments

Comments

@mjtamlyn
Copy link
Member

There is at least once benchmark which checks for compatibility before Django 1.2... It is nice to keep this is as long as possible but with changes to migrations/syncdb, app loading and the startup process it is becoming harder.

I'm not averse to supporting say, all Django >= 1.0, but I feel perhaps 1.4 would be more reasonable at this point.

@akaariai
Copy link
Member

1.4 would be nice to have. I don't care about earlier versions.

EDIT: sorry for closing, I had a sudden stroke ofclumsy fingers syndrome.

@akaariai akaariai reopened this Mar 22, 2015
@mjtamlyn
Copy link
Member Author

As of b52fccf the benchmarks all run back to 1.4. There is at least one failing benchmark for 1.3 due to the addition of the url() function.

If we decide we are happy to drop support for <1.4, we can remove some older compatibility code:

  • the query_exists benchmark is special cased to not run before Django 1.2
  • The template_render benchmark has special paths for Django 1.3 where url reversing in templates was still done by literal rather than by string.

Either way we should document our decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants