feat(margin-app): Lender Withdraw Function #690
+363
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faurdent
requested changes
Mar 3, 2025
| let user_treasury_amount = self.treasury_balances.entry((withdrawer, token)).read(); | ||
| assert(amount <= user_treasury_amount, 'Insufficient user treasury'); | ||
|
|
||
| self.treasury_balances.entry((withdrawer, token)).write(user_treasury_amount - amount); |
Comment on lines
+79
to
+80
| let token_dispatcher = IERC20Dispatcher { contract_address: token }; | ||
| token_dispatcher.transfer(withdrawer, amount); |
There was a problem hiding this comment.
I think it can be one-lined. The number of lines with code will count for the audit price.
Comment on lines
+82
to
+83
| let pool_value = self.pools.entry(token).read(); | ||
| self.pools.entry(token).write(pool_value - amount); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580