-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MarginContract] Lender Withdraw Function #580
Comments
Hi @ djeck1432, I'd like to contribute by implementing the withdraw function. Proposed Solution
Thanks! |
Could I try solving this? I have been recently working on cairo smart contracts and I want to be more immersed in this project in various aspects. To solve this issue I will create events that match the possible outcomes like TokenWithdrawn, InsufficientBalance and InvalidWithdrawal. Then I would write assert macros to verify the conditions are met and then correct the token amounts after the withdrawal. Finally I will write tests possibly using snforge cheatcodes. |
Good day, my name is Goodness, i am a blockchain developer. Please, can I be assigned this issue. |
Good evening sir, |
Hi, I'm Iteooluwakisi! |
This is my first time contributting, and i will like to contribute to your project. With my expertise as a Fullstack Developer, I am confident that I am the right fit for this project. I am ready to contribute, collaborate, and deliver exceptional results. |
I like Pineapple, |
Can I handle this task? |
I will love to take on this task |
I am a Python developer; I can: Build robust web applications using frameworks like Django and Flask. |
Can I tackle this one? |
let me take this please, I will implement the withdraw function, ensuring sufficient balance checks, treasury and pool updates, secure token transfers, and event emission. I will also write tests and documentation. |
Your task is to implement a
withdraw
function for lenders to withdraw their token from our pools.Withdrawn
eventThe text was updated successfully, but these errors were encountered: