Logging is enabled by default

[Rowadz]

I'm uncertain whether this is worth a discussion, but I find it unusual that logging is enabled by default. In my opinion, it should be disabled unless specified.

graphql-yoga/packages/graphql-yoga/src/server.ts

Lines 243 to 251 in bc743aa

	const logger = options?.logging == null ? true : options.logging
	this.logger =
	typeof logger === 'boolean'
	? logger === true
	? createLogger()
	: createLogger('silent')
	: typeof logger === 'string'
	? createLogger(logger)
	: logger

[ardatan]

Error masking is enabled by default, and if an unexpected error is masked, it is printed to the console. Other than that, any messages are printed to the console until the logger is changed to debug.
It doesn't make sense to provide a logger if it is disabled by default, hide the unexpected errors and increase the boilerplate for the user to get those BY default.
You can easily disable it by providing false to logging.

[Rowadz]

That makes sense, I was wondering about the reasoning behind this because the default behavior surprised us after forgetting to disable it.

Going to close the discussion.

Thanks!