-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DatabaseMigrations and AspireShop to EF 9 #401
Comments
We're not planning on updating the samples in this repo to .NET 9 but rather keeping them targeting .NET 8 but using Aspire 9, as .NET 8 is LTS. Using EF Core 9 lifts dependencies to .NET 9 versions thus pulling the project out of LTS so we'll keep them on EF Core 8 too. I'll leave this open though to track doing this work when we move the samples to .NET 10. |
It would be great if you could share the recommended final changes here in this issue if you’re not planning to update the samples. |
I think it would be great to have dotnet9/aspire9 samples in a separate folder, next to the dotnet 8 LTS ones. So we can work with the working clean code versions for dotnet 9. |
We don't want to have to maintain multiple versions of every sample so we decided against this. You can see the recommended final changes over in the https://github.com/DamianEdwards/AspireStarterDb however. |
Thanks for your answer. I understand there is a github repository indicating final changes for aspire v9, dotnet 9, for db development. But isn't this exactly why this repository serves a golden purpose ? It's a go-to for people who want to get a hold of how they can do things, open up a repository, run it and see that it works - out of the box - which is gold, as it's a thousand times better than a description of how things should be done or documentation, as it runs and proves the point of how things should be done. Not having this for another version (v9, v10, ...) is missing out on this exact purpose, in my opinion. Again, your repo is golden. But, given your answer, not for the "current" developers. And I miss that. |
Related to dotnet/aspire#5207
MigrateAsync
MigrateAsync
shouldn't be wrapped in a transaction and execution strategy. This is now done internally, and the explicit wrapping can be detrimental in some cases (for migration operations that can't be executed in a transaction).UseAsyncSeeding
method onDbContextOptionsBuilder
. See Upgrade EF to 9.0 eShop#488 for additional suggestions.Also, use
WaitForResourceAsync(...)
when available.The text was updated successfully, but these errors were encountered: