Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject multidimensional arrays in marshaled members #353

Open
radekdoulik opened this issue Aug 7, 2018 · 2 comments
Open

Reject multidimensional arrays in marshaled members #353

radekdoulik opened this issue Aug 7, 2018 · 2 comments
Labels
callable-wrappers Issues with Java Callable Wrappers enhancement Proposed change to current functionality

Comments

@radekdoulik
Copy link
Member

radekdoulik commented Aug 7, 2018

Based on https://github.com/xamarin/java.interop/pull/351/files#r208002273, we should reject marshaled members with multidimensional C# arrays.

jnimarshalmethod-gen looks like a good place to do it.

@jonpryor
Copy link
Member

jonpryor commented Aug 7, 2018

It doesn't need to just be [Export] members, it needs to be all members for which we generate marshal members.

Granted, it shouldn't be possible for e.g. a virtual method override to contain multidimensional C# arrays, but if they did...we should error.

@radekdoulik radekdoulik changed the title Reject multidimensional arrays for Export attribute Reject multidimensional arrays in marshaled members Aug 7, 2018
@radekdoulik
Copy link
Member Author

That's right, I have updated the title and description. I think I will check it when traversing the API before generating the marshal methods.

@jpobst jpobst added callable-wrappers Issues with Java Callable Wrappers enhancement Proposed change to current functionality labels Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callable-wrappers Issues with Java Callable Wrappers enhancement Proposed change to current functionality
Projects
None yet
Development

No branches or pull requests

3 participants