-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
class-parse output is missing types #358
Comments
Hm.... $ mono /Library/Frameworks/Xamarin.Android.framework/Versions/Current/lib/xbuild/Xamarin/Android/class-parse.exe classes.jar > classes.xml Results in <class
abstract="false"
deprecated="not deprecated"
jni-extends="Landroid/view/ViewGroup;"
extends="android.view.ViewGroup"
extends-generic-aware="android.view.ViewGroup"
final="false"
name="RecyclerView"
jni-signature="Landroid/support/v7/widget/RecyclerView;"
static="false"
visibility="public"> Notice the This is not Additionally, that matches the contents of $ jar tf classes.jar | grep RecyclerView.class
android/support/v7/widget/RecyclerView.class |
My mistake on the I guess class-parse output does include this information, however Here's a diagnostic log: https://gist.github.com/Redth/7122aa97ce049e75c83f7a1a6b5cee9a |
@Redth: Thank you for the diagnostic log. The problem -- which isn't raised very well, sorry -- is this:
Without the <class
abstract="false"
deprecated="not deprecated"
jni-extends="Landroid/view/ViewGroup;"
extends="android.view.ViewGroup"
extends-generic-aware="android.view.ViewGroup"
final="false"
name="RecyclerView"
jni-signature="Landroid/support/v7/widget/RecyclerView;"
static="false"
visibility="public">
<implements
name="android.support.v4.view.ScrollingView"
name-generic-aware="android.support.v4.view.ScrollingView"
jni-type="Landroid/support/v4/view/ScrollingView;" />
<implements
name="android.support.v4.view.NestedScrollingChild2"
name-generic-aware="android.support.v4.view.NestedScrollingChild2"
jni-type="Landroid/support/v4/view/NestedScrollingChild2;" /> Offhand, this seems somewhat absurd to me: if the class isn't final, why do we need to fully resolve all implemented interfaces? Regardless, that's why |
Closing this issue, as Issue #371 is the "actual" issue to fix. |
Take the newest version of the
recyclerview-v7
support library (Download https://dl.google.com/dl/android/maven2/com/android/support/recyclerview-v7/28.0.0-beta01/recyclerview-v7-28.0.0-beta01.aar extract the.aar
, and run themono class-parse.exe classes.jar > out.xml
).Notice that the output api xml does not include:
com.android.support.v7.widget.RecyclerView
, as well asRecyclerView.ViewHolder
,RecyclerView.Adapter
, among other types.This wasn't a problem with v27.1.1 of this library and I don't see a lot that has changed public API wise in v28.x.
The text was updated successfully, but these errors were encountered: