Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ActivatePeer #803

Open
jonpryor opened this issue Feb 18, 2021 · 0 comments
Open

Cleanup ActivatePeer #803

jonpryor opened this issue Feb 18, 2021 · 0 comments
Assignees
@jonpryor
Labels
enhancement Proposed change to current functionality java-interop Runtime bridge between .NET and Java
Milestone
Under consideration

Comments

@jonpryor
Copy link
Member

Commit cba6137 added JniValueManager.ActivatePeer():

public abstract void ActivatePeer (
        IJavaPeerable? self,
        JniObjectReference reference,
        ConstructorInfo cinfo,
        object? []? argumentValues);

However, no code paths actually provide self; when self isn't null, that's a different code path:

https://github.com/xamarin/java.interop/blob/main/src/Java.Interop/Java.Interop/ManagedPeer.cs#L107-L110

The self parameter should be removed.
@jonpryor jonpryor added this to the Under consideration milestone Feb 18, 2021
@jonpryor jonpryor self-assigned this Feb 18, 2021
@jpobst jpobst added enhancement Proposed change to current functionality java-interop Runtime bridge between .NET and Java labels May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonpryor jonpryor

Labels
enhancement Proposed change to current functionality java-interop Runtime bridge between .NET and Java
Projects
None yet
Milestone
Under consideration
Development

No branches or pull requests
2 participants
@jonpryor @jpobst