Transient ProjectReference to .esproj breaks build due to IgnoreJavaScriptOutputAssembly target running before IncludeTransitiveProjectReferences

[duckblaster]

Describe the bug

With this project structure:

• ProjA.csproj
  • ProjectReference: ProjB.csproj
    -ProjB.csproj
  • ProjectReference: ProjC.esproj
• ProjC.esproj

Building the solution fails with because it is looking for ProjC.dll

This is caused by the IgnoreJavaScriptOutputAssembly target in Microsoft.Common.CurrentVersion.targets running before IncludeTransitiveProjectReferences

To Reproduce

Exceptions (if any)

Further technical details

• Include the output of dotnet --info
• The IDE (VS / VS Code/ VS4Mac) you're running on, and its version

[marcpopMSFT]

Do you have an https://aka.ms/binlog to share from the build failure?

[duckblaster]

I have a repo which demonstrates the issue, as well as binlogs and a workaround (see the workaround branch for that): https://github.com/duckblaster/IgnoreJavaScriptOutputAssemblyBugDemo

There also some screenshots from the binlog showing the relevant sections

[duckblaster]

There is also a bug in the Microsoft.VisualStudio.JavaScript.Sdk SDK/Targets/SDK.WebAssets.targets file: the PropertyGroup at the start should be in a .props file, as it is setting defaults for StaticWebAssetSourceId and StaticWebAssetBasePath

[baronfel]

cc @joj

[joj]

I think @javiercn will understand the logic behind this better, but I think the property group is correct where it is. StaticWebAssetSourceId is overridable (but defaults to $(ProjectName), and StaticWebAssetBasePath is set depending on the Source Id. We could make BasePath not change a value if it's already set. I'm not sure if that's something that we want in web assets, though.