Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet-watch] Annotate Hot Reload agent with trimming attributes #46369

Open
tmat opened this issue Jan 28, 2025 · 1 comment
Open

[dotnet-watch] Annotate Hot Reload agent with trimming attributes #46369

tmat opened this issue Jan 28, 2025 · 1 comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Area-Watch

Comments

@tmat
Copy link
Member

tmat commented Jan 28, 2025

Follow up on dotnet/aspnetcore#60030 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Jan 28, 2025
@tmat tmat mentioned this issue Jan 28, 2025
Merged
@pavelsavara
Copy link
Member

pavelsavara commented Jan 29, 2025 •
edited
Loading

It should be covered with tests that the published binaries don't contain the hot reload classes.
In particular wasm target is sensitive to binary size.

@marcpopMSFT marcpopMSFT added Area-Watch and removed untriaged Request triage from a team member labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Area-Watch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmat @pavelsavara @marcpopMSFT