Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet-watch] Review browser launching/refresh corner cases #46382

Open
tmat opened this issue Jan 29, 2025 · 2 comments
Open

[dotnet-watch] Review browser launching/refresh corner cases #46382

tmat opened this issue Jan 29, 2025 · 2 comments
Labels
untriaged Request triage from a team member

Comments

@tmat
Copy link
Member

tmat commented Jan 29, 2025

We don't have many tests covering browser refresh and browser launching.
We should increase test coverage and handle following cases:

  • BrowserRefreshServer may be created even when no browser is launched.
  • When a project is restarted it may change the launch URL. We should not reuse BrowserRefreshServer in such case.

Note: Issue #9038 tracks moving browser launching to dotnet run.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jan 29, 2025
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

1 participant