Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start command logs have wrong timestamps #392

Open
ValentaTomas opened this issue Jun 28, 2024 · 0 comments
Open

Start command logs have wrong timestamps #392

ValentaTomas opened this issue Jun 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ValentaTomas
Copy link
Member

ValentaTomas commented Jun 28, 2024

Problem

Logs from the start command can have timestamps that do not correspond to the actual time if they were captured before starting the sandbox because we might be adding the timestamp later (either in the log collector or right before sending the log).
This can cause confusion both because the log timestamp is wrong and because if there is a timestamp inside the stdout from the start command it will not match the log timestamp.

Fix

Because we don't want to skip sending logs that were created before the sandbox was created we need to set the timestamp in the envd at the time the log was created plus ensure that the timestamps are not overwritten in the logs collector.

@ValentaTomas ValentaTomas added the bug Something isn't working label Jun 28, 2024
@ValentaTomas ValentaTomas changed the title Start command logs timestamps Start command logs have wrong timestamps Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant