Add infrastructure to support relocatable compilations of the invokeHandle/invokeDynamic bytecodes #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dsouzai
commented
Aug 12, 2024
dsouzai
commented
- Add SVM Specific options
- Add new TR_ExternalRelocationTargetKind values
- Add relocations for TR_CallsiteTableEntryAddress
- Add relocations for TR_MethodTypeTableEntryAddress
dsouzai
requested review from
fjeremic,
0xdaryl,
knn-k and
mstoodle
as code owners
|
@jdmpapin do you mind reviewing? |
dsouzai
force-pushed
the
aotmh
branch
2 times, most recently
from
d81b8ed
to
4326da9
Compare
|
Rebased onto the latest |
Signed-off-by: Irwin D'Souza <[email protected]>
Add the following relo kinds: * TR_ValidateDynamicMethodFromCallsiteIndex * TR_ValidateHandleMethodFromCPIndex * TR_CallsiteTableEntryAddress * TR_MethodTypeTableEntryAddress Signed-off-by: Irwin D'Souza <[email protected]>
Signed-off-by: Irwin D'Souza <[email protected]>
Signed-off-by: Irwin D'Souza <[email protected]>
jdmpapin
reviewed
Sep 11, 2024
| @@ -1794,6 +1800,12 @@ void OMR::Power::MemoryReference::accessStaticItem(TR::Node *node, TR::SymbolRef | |||
| loadAddressConstant(cg, true, nodeForSymbol, 1, reg, NULL, false, TR_MethodEnterExitHookAddress); | |||
| return; | |||
| } | |||
| else if (symbol->isCallSiteTableEntry() && !refIsUnresolved && cg->comp()->compileRelocatableCode() | |||
There was a problem hiding this comment.
this else if is missing its closing parenthesis
| @@ -1806,6 +1812,12 @@ void OMR::Power::MemoryReference::accessStaticItem(TR::Node *node, TR::SymbolRef | |||
| loadAddressConstant(cg, true, nodeForSymbol, 1, reg, NULL, false, TR_CallsiteTableEntryAddress); | |||
| return; | |||
| } | |||
| else if (symbol->isMethodTypeTableEntry() && !refIsUnresolved && cg->comp()->compileRelocatableCode() | |||
There was a problem hiding this comment.
another missing parenthesis
|
I think I'll spit this PR into two so that they are more closely coupled to the OJ9 PRs that are dependent on them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.