AArch64: Use enum for dmb limitations #7465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the use of magic numbers for the limitation immediate for dmb instructions with an enum, and adds a debug printer for synchronization instructions to print out the limitation mnemonic rather than the literal hex constant. Signed-off-by: Spencer Comin <[email protected]>
|
Internal JDK11 sanity.functional test: https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/23966/ |
|
The build passed in internal testing, hopefully there are no failures in the actual testing as this PR does not introduce any actual functional changes. |
Spencer-Comin
requested review from
0xdaryl,
knn-k and
mstoodle
as code owners
|
OpenJ9 Note: This requires a coordinated merge with eclipse-openj9/openj9#20188 |
|
Jenkins build aarch64,amac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the use of magic numbers for the limitation immediate for
dmbinstructions with an enum, and adds a debug printer for synchronization instructions to print out the limitation mnemonic rather than the literal hex constant.