From 80960c4b7cb564056ed3dbc3159c3ca81d4bc375 Mon Sep 17 00:00:00 2001 From: umarcor Date: Sun, 26 Dec 2021 07:52:00 +0100 Subject: [PATCH 1/5] clean unused resources --- pyEDAA/ProjectModel/OSVVM.py | 1 - pyEDAA/ProjectModel/__init__.py | 1 - 2 files changed, 2 deletions(-) diff --git a/pyEDAA/ProjectModel/OSVVM.py b/pyEDAA/ProjectModel/OSVVM.py index f72c1324..7b673039 100644 --- a/pyEDAA/ProjectModel/OSVVM.py +++ b/pyEDAA/ProjectModel/OSVVM.py @@ -29,7 +29,6 @@ # SPDX-License-Identifier: Apache-2.0 # ============================================================================ # -from enum import Enum, unique from pathlib import Path from pyTooling.Decorators import export diff --git a/pyEDAA/ProjectModel/__init__.py b/pyEDAA/ProjectModel/__init__.py index 04f75cb6..1f19d226 100644 --- a/pyEDAA/ProjectModel/__init__.py +++ b/pyEDAA/ProjectModel/__init__.py @@ -255,7 +255,6 @@ def __getitem__(self, key: Type[Attribute]): def __setitem__(self, key: Type[Attribute], value: typing_Any): """Index access for setting attributes on this file.""" - x = key.VALUE_TYPE self._attributes[key] = value From 71b52d8b9c420ee373dbef6e39b45c64393a264b Mon Sep 17 00:00:00 2001 From: umarcor Date: Sun, 26 Dec 2021 07:53:50 +0100 Subject: [PATCH 2/5] readme: use asterisks in unordered lits, instead of dashes --- README.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 3664acb4..0088ca41 100644 --- a/README.md +++ b/README.md @@ -99,14 +99,14 @@ for file in designA.Files(fileType=VHDLSourceFile): # References -- [Paebbels/pyIPCMI: pyIPCMI/Base/Project.py](https://GitHub.com/Paebbels/pyIPCMI/blob/master/pyIPCMI/Base/Project.py) -- [VUnit/vunit: vunit/project.py](https://GitHub.com/VUnit/vunit/blob/master/vunit/project.py) -- [PyFPGA/pyfpga: fpga/project.py](https://GitHub.com/PyFPGA/pyfpga/blob/main/fpga/project.py) -- [olofk/fusesoc: fusesoc/capi2/core.py](https://GitHub.com/olofk/fusesoc/blob/master/fusesoc/capi2/core.py) -- [XedaHQ/xeda: xeda/flows/flow.py](https://GitHub.com/XedaHQ/xeda/blob/master/xeda/flows/flow.py) -- [tsfpga/tsfpga: tsfpga/build_project_list.py](https://gitlab.com/tsfpga/tsfpga/-/blob/master/tsfpga/build_project_list.py) -- [hdl-make: hdlmake/](https://ohwr.org/project/hdl-make/tree/master/hdlmake) -- [OSVVM/OSVVM-Scripts: OsvvmProjectScripts.tcl](https://GitHub.com/OSVVM/OSVVM-Scripts/blob/master/OsvvmProjectScripts.tcl) +* [Paebbels/pyIPCMI: pyIPCMI/Base/Project.py](https://GitHub.com/Paebbels/pyIPCMI/blob/master/pyIPCMI/Base/Project.py) +* [VUnit/vunit: vunit/project.py](https://GitHub.com/VUnit/vunit/blob/master/vunit/project.py) +* [PyFPGA/pyfpga: fpga/project.py](https://GitHub.com/PyFPGA/pyfpga/blob/main/fpga/project.py) +* [olofk/fusesoc: fusesoc/capi2/core.py](https://GitHub.com/olofk/fusesoc/blob/master/fusesoc/capi2/core.py) +* [XedaHQ/xeda: xeda/flows/flow.py](https://GitHub.com/XedaHQ/xeda/blob/master/xeda/flows/flow.py) +* [tsfpga/tsfpga: tsfpga/build_project_list.py](https://gitlab.com/tsfpga/tsfpga/-/blob/master/tsfpga/build_project_list.py) +* [hdl-make: hdlmake/](https://ohwr.org/project/hdl-make/tree/master/hdlmake) +* [OSVVM/OSVVM-Scripts: OsvvmProjectScripts.tcl](https://GitHub.com/OSVVM/OSVVM-Scripts/blob/master/OsvvmProjectScripts.tcl) From 8dca21ca6f0468126c655bf6454e38d1cff739ef Mon Sep 17 00:00:00 2001 From: umarcor Date: Sun, 26 Dec 2021 08:08:29 +0100 Subject: [PATCH 3/5] readme: fix linter warnings with regard to blank lines --- README.md | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 0088ca41..77ae7e49 100644 --- a/README.md +++ b/README.md @@ -47,13 +47,15 @@ such a model, while supporting multiple input sources. * top-down (project → design → fileset → file) or * bottom-up (file → fileset → design → project) or * parsing a project file. + * Designs, filesets and files can use absolute or relative paths. * `ResolvedPath` returns the resolved absolute path to an object. + * Projects, designs, filesets and files can be validated (e.g. if the path exists). + * Projects, designs, filesets and files can have user-defined attributes. * User-defined attributes are resolved bottom-up. - # Project File Readers ## OSVVM `*.pro` File Reader @@ -67,10 +69,10 @@ ProjectModel can read `*.xpr` files and extract source, constraint and simulatio files while preserving the fileset structure. # Use Cases + * Reading OSVVM's `*.pro` files. * Reading Xilinx Vivado's `*.xpr` files. - # Examples ```python @@ -96,7 +98,6 @@ for file in designA.Files(fileType=VHDLSourceFile): print(f" {file.Path}") ``` - # References * [Paebbels/pyIPCMI: pyIPCMI/Base/Project.py](https://GitHub.com/Paebbels/pyIPCMI/blob/master/pyIPCMI/Base/Project.py) @@ -108,8 +109,6 @@ for file in designA.Files(fileType=VHDLSourceFile): * [hdl-make: hdlmake/](https://ohwr.org/project/hdl-make/tree/master/hdlmake) * [OSVVM/OSVVM-Scripts: OsvvmProjectScripts.tcl](https://GitHub.com/OSVVM/OSVVM-Scripts/blob/master/OsvvmProjectScripts.tcl) - - # Contributors * [Patrick Lehmann](https://GitHub.com/Paebbels) (Maintainer) @@ -117,7 +116,6 @@ for file in designA.Files(fileType=VHDLSourceFile): * [Stefan Unrein](https://GitHub.com/stefanunrein) * [and more...](https://GitHub.com/edaa-org/pyEDAA.ProjectModel/graphs/contributors) - # License This Python package (source code) licensed under [Apache License 2.0](LICENSE.md). From 17eb6272ec1aa67918c32093d7f85871cd7d0f94 Mon Sep 17 00:00:00 2001 From: umarcor Date: Sun, 26 Dec 2021 08:09:14 +0100 Subject: [PATCH 4/5] tests/VivadoProject/StopWatch/README: fix linter warnings with regard to blank lines --- tests/VivadoProject/StopWatch/README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/VivadoProject/StopWatch/README.md b/tests/VivadoProject/StopWatch/README.md index e6ee9329..98e794f3 100644 --- a/tests/VivadoProject/StopWatch/README.md +++ b/tests/VivadoProject/StopWatch/README.md @@ -2,8 +2,6 @@ The VHDL StopWatch Vivado project is the solution to the **Professional VHDL** 5-days class offered by PLC2. - - # License Licensed under [MIT License](LICENSE.md). From cda002d09376fd6728942d7980e4d57e40673b1f Mon Sep 17 00:00:00 2001 From: umarcor Date: Sun, 26 Dec 2021 08:13:39 +0100 Subject: [PATCH 5/5] github/pull_request_template: fix linter warnings with regard to blank lines --- .github/pull_request_template.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7a345ae6..5e16226d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,8 +1,11 @@ # New Features + * tbd # Changes + * tbd # Bug Fixes + * tbd