Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_line_length support #45

Open
greut opened this issue Nov 13, 2019 · 2 comments · May be fixed by #66
Open

max_line_length support #45

greut opened this issue Nov 13, 2019 · 2 comments · May be fixed by #66

Comments

@greut
Copy link
Member

greut commented Nov 13, 2019

Would it make sense to have a MaxLineLength int property where any off value would be translated to a 0.

https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
@silverwind silverwind mentioned this issue May 13, 2020
Merged
@silverwind
Copy link
Contributor

silverwind commented May 14, 2020 •
edited
Loading

Off value represented as a number should ideally be positive infinity but such values are always problematic in encodings like JSON, so I guess 0 is an acceptable compatibility approach.

@greut
Copy link
Member Author

greut commented May 14, 2020

zero is the value that would work best with JSON serialization, assuming omitempty. You have always access to the raw values.

I'm supporting this in the linter although it could be brought back here as well if it helps anybody else. https://gitlab.com/greut/eclint/-/blob/master/definition.go#L59-70

@greut greut linked a pull request May 18, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

definition: max_line_length support editorconfig/editorconfig-core-go
2 participants
@greut @silverwind