You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I write a demo, and it uses npx patch-package is-number, then Cannot find module 'node:process'
Environment: Node.js 14.7.0
yaml: 2.7.0
To Reproduce
1.create a folder dds
2.npm init -y
3.npm install patch-package then the version of node_modules/yaml is 2.7.0
4. modify node_modules/isarray/index.js
var toString = {}.toString;
module.exports = Array.isArray || function (arr) {
console.log(111);
return toString.call(arr) == '[object Array]';
};
npx patch-package isarray and then Cannot find module 'node:process'
Yeah, the engines.node dependency should be updated to >= 14.18. Previously the minimum was in practice Node.js 14.6, as that introduces private method support.
I should also come up with a better expression for execution environment compatibility. Maybe something along these lines?
Execution environments that have reached end-of-life are only supported with the latest extended support release.
So e.g. Node.js would only be guaranteed support for 14.21.3, unless yet another release of it is made.
Node.js 14 EOL was in April 2023, and its earliest supported version (14.18.0) was released in September 2021. I think requiring an update to at least that is a reasonable request, and so the changes in yaml 2.7.0 should not be considered breaking. Essentially, if you're using an out-of-date version of an EOL'd engine, it's not reasonable to expect all package updates to "just work".
Describe the bug
I write a demo, and it uses
npx patch-package is-number
, thenCannot find module 'node:process'
yaml
: 2.7.0To Reproduce
1.create a folder
dds
2.
npm init -y
3.
npm install patch-package
then the version ofnode_modules/yaml
is2.7.0
4. modify
node_modules/isarray/index.js
npx patch-package isarray
and thenCannot find module 'node:process'
if I
npm install [email protected]
,it's ok.nvm use v16.18.0
it is also ok;look the
node_modules/patch-package/package.json
, we can find thatpatch-package
dependences"yaml": "^2.2.2"
.So I think the
[email protected]
is not support the node14.7.0
.Before you publish the tag2.7.0
, it works well.The text was updated successfully, but these errors were encountered: