From 4c32ff34692e15441443f5d8ceba16be1517e702 Mon Sep 17 00:00:00 2001 From: Anderson Queiroz Date: Tue, 11 Feb 2025 17:24:25 +0100 Subject: [PATCH] wip --- filebeat/input/log/input.go | 3 +++ libbeat/publisher/pipeline/pipeline.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/filebeat/input/log/input.go b/filebeat/input/log/input.go index f8c2e6b1c47a..cfcbe97012ad 100644 --- a/filebeat/input/log/input.go +++ b/filebeat/input/log/input.go @@ -138,6 +138,9 @@ func NewInput( // The outlet generated here is the underlying outlet, only closed // once all workers have been shut down. // For state updates and events, separate sub-outlets will be used. + // TODO: there is neither ID in the context nor on inputConfig. It seems + // there is no ID at all. It's not publishing input metrics anyway. Where + // did that chart come from? https://github.com/elastic/beats/issues/42325#issuecomment-2648776284 out, err := outlet.Connect(cfg) if err != nil { return nil, err diff --git a/libbeat/publisher/pipeline/pipeline.go b/libbeat/publisher/pipeline/pipeline.go index c913c7ab17c3..8ef06ff91baf 100644 --- a/libbeat/publisher/pipeline/pipeline.go +++ b/libbeat/publisher/pipeline/pipeline.go @@ -189,7 +189,7 @@ func (p *Pipeline) Connect() (beat.Client, error) { // ConnectWith create a new Client for publishing events to the pipeline. // The client behavior on close and ACK handling can be configured by setting // the appropriate fields in the passed ClientConfig. -// If not set otherwise the defaut publish mode is OutputChooses. +// If not set otherwise the default publish mode is OutputChooses. // // It is responsibility of the caller to close the client. func (p *Pipeline) ConnectWith(cfg beat.ClientConfig) (beat.Client, error) {