Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codegen PR applies new logic to how each API function determines where to put passed parameters.
Up to now the logic has been as follows:
body
param from the spec, put it in the JSON bodypath
param, put it in the URL pathFor 9.x and from this PR forward, the logic changes to:
body
param from the spec, put it in the JSON bodypath
param, put it in the URL pathquery
param or a "common" query param (e.g.pretty
,error_trace
), put it in the querystringThis change also updates each API function to only instantiate its arrays of accepted body/path/query param names once per client instance rather than during every function call, by moving the array values up to the constructor or module, depending on which is available.
This change is being made as part of the solution to #2584.