Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The web content printed on paper is too small #45080

Open
3 tasks done
giangtran99 opened this issue Dec 22, 2024 · 2 comments · May be fixed by #45218
Open
3 tasks done

The web content printed on paper is too small #45080

giangtran99 opened this issue Dec 22, 2024 · 2 comments · May be fixed by #45218
Assignees
@codebytere
Labels
33-x-y 34-x-y 35-x-y component/printing platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@giangtran99
Copy link

giangtran99 commented Dec 22, 2024 •
edited
Loading

Preflight Checklist

Problem Description

Problem : The web content printed on physical paper is too small
This issue ( ref to #39179 ) is closed but it seems wasn't resolved and many develpers complain about it so i want to reopen this issue

Proposed Solution

As my investigation , chromium changes in https://chromium-review.googlesource.com/c/chromium/src/+/5349263?tab=comments indicate that kCenterShrinkToFitPaper doesn't scale up when web content is small relative to paper size .
@codebytere Please review this changes and consider set kFitToPrintableArea for default option when silent mode is enable.

Alternatives Considered

Other solution is add "printScaleOption" to electron webContent.print() settings and pass it to settings.print_scaling_option's printer module in chromium

Additional Information

No response
@VerteDinde
Copy link
Member

@giangtran99 Is this an enhancement or a bug? This seems like a bug unless I'm reading incorrectly - has it always been broken?

@giangtran99
Copy link
Author

giangtran99 commented Dec 25, 2024 •
edited
Loading

@VerteDinde that is a bug but i just want to use enhancement template for proposing solution and,

yes it has always been broken since October, 2023 when i have printed webcontent on physical paper

@codebytere codebytere added component/printing status/confirmed A maintainer reproduced the bug or agreed with the feature platform/all 33-x-y 34-x-y 35-x-y and removed enhancement ✨ labels Jan 16, 2025
@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 34-x-y Jan 16, 2025
@codebytere codebytere linked a pull request Jan 16, 2025 that will close this issue
Open
3 tasks
@codebytere codebytere self-assigned this Jan 16, 2025
@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 35-x-y Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codebytere codebytere

Labels
33-x-y 34-x-y 35-x-y component/printing platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
34-x-y
Status: 👀 Unsorted Items
35-x-y
Status: 👀 Unsorted Items
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: page scaling in silent mode printing electron/electron
3 participants
@codebytere @VerteDinde @giangtran99