Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont release known broken artefacts. #2162

Open
FSG-Cat opened this issue Feb 27, 2025 · 1 comment
Open

Dont release known broken artefacts. #2162

FSG-Cat opened this issue Feb 27, 2025 · 1 comment
Labels
A-Packaging Packaging, signing, releasing T-Enhancement T-Task Tasks for the team like planning Z-Platform-Specific Z-Upstream

Comments

@FSG-Cat
Copy link

FSG-Cat commented Feb 27, 2025

Your use case

Dont build release artefacts for Nightly or Release for a given platform if CI for that platform fails.

Have you considered any alternatives?

Making the launcher app fault proof by automatic rollback when the update fails could work.

Additional context

No response

@dosubot dosubot bot added A-Packaging Packaging, signing, releasing T-Task Tasks for the team like planning labels Feb 27, 2025
@t3chguy
Copy link
Member

t3chguy commented Feb 27, 2025

Dont build release artefacts for Nightly or Release for a given platform if CI for that platform fails.

CI didn't fail. The smoke tests under Playwright seemed fine until after https://github.com/element-hq/element-desktop/actions/workflows/build_and_test.yaml

Making the launcher app fault proof by automatic rollback when the update fails could work.

That's be a request for the upstream of whichever platform you're running on. Squirrel.Windows, Squirrel.Mac etc, our code isn't even reaching execution in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Packaging Packaging, signing, releasing T-Enhancement T-Task Tasks for the team like planning Z-Platform-Specific Z-Upstream
Projects
None yet
Development

No branches or pull requests

2 participants