Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adw-entry-apply-symbolic #742

Open
ztefn opened this issue Jan 22, 2025 · 4 comments
Open

adw-entry-apply-symbolic #742

ztefn opened this issue Jan 22, 2025 · 4 comments

Comments

@ztefn
Copy link

ztefn commented Jan 22, 2025

Problem

Missing icon for apply button in AdwEntryRow.

Image

Proposal

Add specific icon or just create symbolic links to check-active-symbolic, which would look quite fitting:

Image

Prior Art (Optional)

This is what it looks like with Adwaita icon theme:

Image

@wpkelso wpkelso transferred this issue from elementary/icons Jan 29, 2025
@wpkelso wpkelso transferred this issue from elementary/gala Jan 29, 2025
@ztefn
Copy link
Author

ztefn commented Jan 29, 2025

@wpkelso Why are you moving this issue around?

@wpkelso
Copy link
Member

wpkelso commented Jan 29, 2025

My understanding ( @danirabbit please correct me if I'm wrong ) is that we're trying to eventually pare elementary/icons down to only freedesktop.org spec icons, and move icons used by multiple apps that are outside the fd.o spec into granite, thus the move here. The intermediate move to Gala was because I got my G names mixed up.

@danirabbit
Copy link
Member

Yup that's right. Basically, folks can still have breakage by changing their system icon theme, so this needs to be loaded at the platform level to make sure it never breaks. Adwaita loads these icons for Adwaita apps, so our equivalent platform library is Granite

@ztefn
Copy link
Author

ztefn commented Jan 30, 2025

Thanks for the explanation! That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants