Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML syntax highlighting changes? #610

Open
jimeh opened this issue May 12, 2024 · 0 comments
Open

YAML syntax highlighting changes? #610

jimeh opened this issue May 12, 2024 · 0 comments

Comments

@jimeh
Copy link
Contributor

jimeh commented May 12, 2024

Commit 9c3c77d changed syntax highlight colors for keys in YAML files. And I'm just curious as to what the underlying reason for this change was.

While the old query marked the key nodes as @variable, it was to retain as close as possibly syntax highlighting to yaml-mode without tree-sitter, so as to not feel like too drastic of a change when enabling tree-sitter-mode.

Screenshots

Here's a few screenshots demonstrating how 9c3c77d has affected things:

After commit 9c3c77d

Screenshot 2024-05-12 at 22 13 22

Before commit 9c3c77d

Screenshot 2024-05-12 at 22 13 37

yaml-mode without tree-sitter-mode

Screenshot 2024-05-12 at 22 13 49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant