-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite all advice functions with nadvice #147
Comments
IMO, they shouldn't use advice at all, advice just an adhoc solution for modify function in other packages without touch their source code. Using specific keymap would be better. Please have a look at #150 |
Maybe we can get some inspiration from https://github.com/emacs-helm/helm/blob/master/helm-occur.el#L301 |
I know, but there are still remained another |
cireu
added
2.0.0
Will be contained in Release 2.0.0
and removed
2.0.0
Will be contained in Release 2.0.0
labels
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nowadays, advice with
defadvice
is not a good choice.So we should rewrite all advice functions with
nadvice
.The text was updated successfully, but these errors were encountered: