Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance line number's UX #157

Open
conao3 opened this issue Aug 13, 2019 · 2 comments
Open

Enhance line number's UX #157

conao3 opened this issue Aug 13, 2019 · 2 comments

Comments

@conao3
Copy link
Collaborator

conao3 commented Aug 13, 2019

Re #113.

@conao3 Yes, feel free to close this PR, as I don't intend to work on it anymore.
If I may, I'd recommend rewriting the line numbers to use text-properties to store and retrieve them, and perhaps using overlays to optionally display them. I think that will improve performance and flexibility.

@cireu
Copy link
Collaborator

cireu commented Aug 14, 2019

Not only make it optional, current line number implementation has awful User Experience.

  1. Any regex that matching a digit will match line number. Mentioned in Can digits in line numbers be excluded in matching? #45

  2. Misalignment, old implementation simply add one space after line number, so the swoop buffer will look like

图片

I had made some changes in https://github.com/cireu/helm-swoop fix issues I mentioned above. But I still need some time to test and merge them.

@cireu
Copy link
Collaborator

cireu commented Aug 14, 2019

and perhaps using overlays to optionally display them.

Can overlays be put on empty lines? @alphapapa

@cireu cireu changed the title Make line numbers optional Enhance line number's UX Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants