helm-swoop does not work as expected #175

brunosmmm · 2020-01-20T16:38:06Z

Summary:

helm-swoop does not work as expected

Reproducing:

Clean emacs installation (version 26.3 here)
Install helm-swoop from melpa or helm/helm-swoop from source
M-x helm-swoop in default buffer

Expected:

helm-swoop buffer displays only lines with occurrences of the search string, able to jump between buffer locations by navigating up/down helm-swoop buffer

Observed:

helm-swoop buffer displays entire buffer that is being searched with occurences highlighted, not just lines with occurrences, making it impossible to jump between occurrences

Details:

Tracked this down to helm commit emacs-helm/helm@c09329cd8. Current melpa version is already newer thant this commit, so anyone installing via melpa or source will see the issue

The text was updated successfully, but these errors were encountered:

conao3 · 2020-01-20T17:20:14Z

I've seen this issue too. But I haven't enough time to investigate in it. How about @cireu?

fadecaps · 2020-01-21T13:32:30Z

Seeing the same issue on Spacemacs 0.300.0 w/ Emacs 26.3 on Windows 7

ianbarton · 2020-01-21T16:39:27Z

Same here. Emacs 26.3 on ArchLinux.

This reported at emacsorphanage#175. This caused by helm commit emacs-helm/helm@c09329c. helm--candidates-in-buffer-p return value changed nil to t by that helm commit.

duianto · 2020-01-21T21:53:00Z

I just updated the packages in Spacemacs and the temporary workaround seems to be working. Thanks.

Windows 1903

#### System Info :computer:
- OS: windows-nt
- Emacs: 26.3
- Spacemacs: 0.300.0
- Spacemacs branch: develop (rev. 2bec3bb71)
- Graphic display: t
- Distribution: spacemacs
- Editing style: vim
- Completion: helm
- Layers:
```elisp
(autohotkey auto-completion colors command-log emacs-lisp git helm imenu-list markdown multiple-cursors
            (org :variables org-agenda-files
                 '("c:/Users/username/org/notes.org"))
            (shell :variables shell-default-shell 'eshell)
            spell-checking syntax-checking treemacs version-control)
```
- System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS THREADS LCMS2

ianbarton · 2020-01-22T13:56:18Z

Thanks. Now working OK for me.

hajovonta · 2020-05-21T10:21:37Z

I see this again, on the latest emacs, helm, helm-swoop (no Spacemacs or other configs)
Can you please confirm?

conao3 · 2020-05-21T10:43:37Z

I see it seems works well.

init.el

;; ~/.debug.emacs.d/helm-swoop/init.el

;; you can run like 'emacs -q -l ~/.debug.emacs.d/{{pkg}}/init.el'
(when load-file-name
  (setq user-emacs-directory
        (expand-file-name (file-name-directory load-file-name))))

(prog1 "prepare leaf"
  (prog1 "package"
    (custom-set-variables
     '(package-archives '(("org"   . "https://orgmode.org/elpa/")
                          ("melpa" . "https://melpa.org/packages/")
                          ("gnu"   . "https://elpa.gnu.org/packages/"))))
    (package-initialize))

  (prog1 "leaf"
    (unless (package-installed-p 'leaf)
      (package-refresh-contents)
      (package-install 'leaf))))

(leaf helm
  :load-path* "site-lisp/helm"
  :require helm-config
  :leaf-defer nil
  :init
  (leaf async :require t :load-path* "site-lisp/emacs-async")
  (leaf popup :require t :load-path* "site-lisp/popup-el")
  :bind (("M-x"     . helm-M-x)
         ("C-x r b" . helm-filtered-bookmarks)
         ("C-x C-f" . helm-find-files))
  :custom ((helm-mode . t))
  :config
  (leaf helm-swoop
    :load-path* "site-lisp/helm-swoop"
    :require t
    :bind (("M-i"     . helm-swoop)
           ("M-C-i"   . helm-swoop-back-to-last-point)
           ("C-c M-i" . helm-multi-swoop)
           ("C-x M-i" . helm-multi-swoop-all)
           (:isearch-mode-map ("M-i" . helm-swoop-from-isearch))
           (:helm-swoop-map   ("M-i" . helm-multi-swoop-all-from-helm-swoop)))))

Run

emacs -q -l ~/.debug.emacs.d/helm-swoop/init.el

Version info

conao-manjaro-helios:~/.debug.emacs.d/helm-swoop/site-lisp conao
$ find . -mindepth 1 | xargs -I^ -t sh -c "cd ^; git log --oneline | head -1"
sh -c 'cd ./helm; git log --oneline | head -1' 
4ff354ef Update version number in helm.el
sh -c 'cd ./popup-el; git log --oneline | head -1' 
4839797 Looking for new maintainer
sh -c 'cd ./emacs-async; git log --oneline | head -1' 
86aef2c Untabify and indent-buffer (#119)
sh -c 'cd ./helm-swoop; git log --oneline | head -1' 
2efc552 Merge pull request #185 from palikar/adding-openning-other-window

cireu · 2020-05-21T11:03:09Z

I see this again, on the latest emacs, helm, helm-swoop (no Spacemacs or other configs)
Can you please confirm?

What's your meaning of latest emacs?. Do you mean master branch?

hajovonta · 2020-05-21T11:09:15Z

GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2020-05-19

yesterday I updated emacs, and all packages, so I suspect something went wrong with either of the new package versions.

conao3 · 2020-05-21T12:05:40Z

I compile HEAD Emacs and tested again. However helm-swoop works well for me.
Please confirm @cireu too?

hajovonta · 2020-05-21T12:26:15Z

interesting. I updated several packages yesterday, and it doesn't work properly since then.

cireu · 2020-05-21T16:32:19Z

I compile HEAD Emacs and tested again. However helm-swoop works well for me.
Please confirm @cireu too?

It also works for me

hajovonta · 2020-05-21T19:07:37Z

I accept that it works for you, maybe the error is with my configuration.
I can't run the init.el you provided without errors, by the way.
Thanks anyway.

conao3 · 2020-05-21T19:22:51Z

Please paste backtrace for my reference.

hajovonta · 2020-05-21T20:14:33Z

I have packages in ~/.emacs.d/elpa/ dir, not in site-lisp.
Also, I have helm.el in helm-core-3.6.2/ dir, not in helm-3.6.2/, for some reason.
I tried to rewrite the directories according to what makes sense, but no luck with helm-swoop :(
Got this:

Warning (leaf): Error in `helm-swoop' block.  Error msg: Cannot open load file: No such file or directory, helm-lib
Warning (initialization): Your ‘load-path’ seems to contain
your ‘.emacs.d’ directory: ~/.emacs.d/elpa/helm-swoop-2.0.0
This is likely to cause problems...
Consider using a subdirectory instead, e.g.: /home/<user>/.emacs.d/elpa/helm-swoop-2.0.0/lisp

conao3 · 2020-05-21T22:56:01Z

please install git version dependencies in site-lisp where located the same level at init.el.
I repaste version info.

conao-manjaro-helios:~/.debug.emacs.d/helm-swoop/site-lisp conao
$ find . -mindepth 1 | xargs -I^ -t sh -c "cd ^; git log --oneline | head -1"
sh -c 'cd ./helm; git log --oneline | head -1' 
4ff354ef Update version number in helm.el
sh -c 'cd ./popup-el; git log --oneline | head -1' 
4839797 Looking for new maintainer
sh -c 'cd ./emacs-async; git log --oneline | head -1' 
86aef2c Untabify and indent-buffer (#119)
sh -c 'cd ./helm-swoop; git log --oneline | head -1' 
2efc552 Merge pull request #185 from palikar/adding-openning-other-window

More directory, please prepare this structure.
Then run as emacs -q -l ~/.debug.emacs.d/helm-swoop/init.el.

$ pwd
/home/conao/.debug.emacs.d/helm-swoop

$ tree -L 2
.
├── init.el
└── site-lisp
    ├── emacs-async
    ├── helm
    ├── helm-swoop
    └── popup-el

conao3 · 2020-05-21T23:04:43Z

When missing helm-autoloads.el, make autoloads in helm directory is required.

cireu · 2020-05-27T17:30:03Z

Any feedback on this bug, is this still make you annoyed? @hajovonta

hajovonta · 2020-05-27T19:55:52Z

Hi @cireu ,
I couldn't manage to get it work again. I let this problem go.
Thanks for your efforts.

brunosmmm mentioned this issue Jan 20, 2020

helm-swoop does not work as expected anymore syl20bnr/spacemacs#13196

Closed

conao3 mentioned this issue Jan 21, 2020

Temporary workaround; not update candidate issue #176

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

helm-swoop does not work as expected #175

helm-swoop does not work as expected #175

brunosmmm commented Jan 20, 2020 •

edited

Loading

conao3 commented Jan 20, 2020

fadecaps commented Jan 21, 2020

ianbarton commented Jan 21, 2020

duianto commented Jan 21, 2020 •

edited

Loading

ianbarton commented Jan 22, 2020

hajovonta commented May 21, 2020

conao3 commented May 21, 2020

cireu commented May 21, 2020

hajovonta commented May 21, 2020

conao3 commented May 21, 2020

hajovonta commented May 21, 2020

cireu commented May 21, 2020

hajovonta commented May 21, 2020

conao3 commented May 21, 2020

hajovonta commented May 21, 2020

conao3 commented May 21, 2020

conao3 commented May 21, 2020

cireu commented May 27, 2020

hajovonta commented May 27, 2020

helm-swoop does not work as expected #175

helm-swoop does not work as expected #175

Comments

brunosmmm commented Jan 20, 2020 • edited Loading

Summary:

Reproducing:

Expected:

Observed:

Details:

conao3 commented Jan 20, 2020

fadecaps commented Jan 21, 2020

ianbarton commented Jan 21, 2020

duianto commented Jan 21, 2020 • edited Loading

ianbarton commented Jan 22, 2020

hajovonta commented May 21, 2020

conao3 commented May 21, 2020

cireu commented May 21, 2020

hajovonta commented May 21, 2020

conao3 commented May 21, 2020

hajovonta commented May 21, 2020

cireu commented May 21, 2020

hajovonta commented May 21, 2020

conao3 commented May 21, 2020

hajovonta commented May 21, 2020

conao3 commented May 21, 2020

conao3 commented May 21, 2020

cireu commented May 27, 2020

hajovonta commented May 27, 2020

brunosmmm commented Jan 20, 2020 •

edited

Loading

duianto commented Jan 21, 2020 •

edited

Loading