Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecationWorkflow does not exist? #100

Open
mydea opened this issue Mar 2, 2021 · 2 comments
Open

deprecationWorkflow does not exist? #100

mydea opened this issue Mar 2, 2021 · 2 comments

Comments

@mydea
Copy link

mydea commented Mar 2, 2021

I just tried installing the 2.0.0-beta.2, and run deprecationWorkflow.flushDeprecations() as the readme says, but it complains that deprecationWorkflow is not defined for me?
@mydea
Copy link
Author

mydea commented Mar 3, 2021

I digged into it a bit, and it seems that in my (fairly normal, up to date Octane) app this line:

https://github.com/mixonic/ember-cli-deprecation-workflow/blob/cb87969bc55c45c9ca042ab9ab2ee7428c4dfb8d/index.js#L26

always returns false, because we have tests disabled by default to speed up the dev build.
Wouldn't it make sense to check if env === "development" (maybe in addition)?

@mydea mydea mentioned this issue May 25, 2021
Closed
@nlfurniss
Copy link
Contributor

Seeing the same issue with 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid using Ember global mydea/ember-cli-deprecation-workflow
2 participants
@nlfurniss @mydea