Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship 2.0 #109

Closed
5 tasks done
mixonic opened this issue May 27, 2021 · 6 comments
Closed
5 tasks done

Ship 2.0 #109

mixonic opened this issue May 27, 2021 · 6 comments
Labels
2.0 2.0 blockers, see https://github.com/mixonic/ember-cli-deprecation-workflow/issues/109

Comments

@mixonic
Copy link
Member

mixonic commented May 27, 2021

This issue tracks work blocking the release of a final 2.0 release.

ember-cli-deprecation-workflow 2.0 will introduce the following breaking changes:

  • Ember 2.12-LTS is the minimum version of Ember supported. Support for older versions of Ember (for example back to 1.13.0) is removed.
  • Ember CLI 3.16+ is the minimum version of Ember CLI supported.
  • Many dependency changes land in 2.0
  • Node 12.x and >= 14.x are the minimum versions of Node supported. Support for Node 6.x, 8.x, 10.x, 11.x, and 13.x is removed.

TODO:

See also https://github.com/mixonic/ember-cli-deprecation-workflow/labels/2.0

@mixonic mixonic added the 2.0 2.0 blockers, see https://github.com/mixonic/ember-cli-deprecation-workflow/issues/109 label May 27, 2021
@chancancode
Copy link

Probably a good opportunity to drop Node 10 as well?

@mixonic
Copy link
Member Author

mixonic commented May 27, 2021

I would like to support old versions of Ember, as the point of this library is to help complex/large apps upgrade and there are many not on 3.16.

However I have no problem requiring Ember CLI 3.16+ and something newer than Node 10. The addon isn't helping upgrade those things, apps can upgrade them independently of Ember and should.

@chancancode
Copy link

Yeah I think that’s consistent with the support policies. Since node 10 is EOL, if we don’t drop it now we are going to have issues when other deps start dropping node 10, especially when not all of them bump major when doing so.

@rwjblue
Copy link
Member

rwjblue commented May 27, 2021

Ya, let’s make node engines 12.* || >= 14 (dropping 10 and 13, both of which are EOL).

@gilest
Copy link

gilest commented Jul 11, 2021

This can be closed, yes?

@mixonic
Copy link
Member Author

mixonic commented Jul 19, 2021

🎉 Yep!

@mixonic mixonic closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 2.0 blockers, see https://github.com/mixonic/ember-cli-deprecation-workflow/issues/109
Projects
None yet
Development

No branches or pull requests

4 participants