Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id: ember-global deprecation is not silenced #134

Open
snewcomer opened this issue Nov 11, 2021 · 2 comments
Open

id: ember-global deprecation is not silenced #134

snewcomer opened this issue Nov 11, 2021 · 2 comments

Comments

@snewcomer
Copy link

This seems like a timing issue in tests. Have both of these in the config file.

		{ handler: 'silence', matchId: 'ember-global' }, 
		{ handler: 'silence', matchMessage: /Usage of the Ember Global is deprecated/ },

Screen Shot 2021-11-11 at 11 31 28 AM

@mixonic
Copy link
Member

mixonic commented Jan 27, 2022

I'm not sure this is enough to trivially reproduce the issue. There isn't anything special about the global deprecation matcher. It should be easy to triage in your application if the deprecation handler code path is being hit at all.

@Gaurav0
Copy link
Contributor

Gaurav0 commented Aug 5, 2022

It seems all of the deprecation messages generated here, which we can collectively refer to as "build time deprecations", aren't silenced / thrown if referenced in the deprecation workflow file.

https://github.com/emberjs/ember.js/blob/master/lib/index.js#L66-L134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants