Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint conflict with ember-cli #50

Open
jamesarosen opened this issue Jun 28, 2018 · 1 comment
Open

eslint conflict with ember-cli #50

jamesarosen opened this issue Jun 28, 2018 · 1 comment

Comments

@jamesarosen
Copy link

jamesarosen commented Jun 28, 2018

By default, ember-cli adds the following to .eslintrc.js:

// node files
{
  env: {
    browser: false,
    node: true,
  },
  files: [
    'ember-cli-build.js',
    'testem.js',
    'blueprints/*/index.js',
    'config/**/*.js',
    'lib/*/index.js',
  ],
  parserOptions: {
    ecmaVersion: 2015,
    sourceType: 'script',
  },
},

That means the output to be copied to config/deprecation-workflow.js should have something like

/* eslint-env browser */

or

/* globals window */

at the top.

Or, alternatively, ember-cli-deprecation-workflow should add

excludedFiles: [ 'config/deprecation-workflow.js' ],

to the relevant overrides section.

@mixonic
Copy link
Member

mixonic commented Nov 23, 2021

I think this implies that workflow creates the file on installation, which it could. It doesn't today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants