Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monkey-patching does not work with addons in yarn workspaces #65

Open
runspired opened this issue Aug 29, 2019 · 1 comment
Open

monkey-patching does not work with addons in yarn workspaces #65

runspired opened this issue Aug 29, 2019 · 1 comment

Comments

@runspired
Copy link

I suspect it may have something to do with how it is reaching in to discover ember-source files

stack: TypeError: Cannot read property '_addon' of undefined
    at Class._monkeyPatch_EmberDeprecate (/Users/cthoburn/Github/data/node_modules/ember-cli-deprecation-workflow/index.js:63:39)
    at Class.setupPreprocessorRegistry (/Users/cthoburn/Github/data/node_modules/ember-cli-deprecation-workflow/index.js:122:12)
    at /Users/cthoburn/Github/data/node_modules/ember-cli-preprocess-registry/preprocessors.js:27:13
    at Array.forEach (<anonymous>)
    at setupRegistryForEachAddon (/Users/cthoburn/Github/data/node_modules/ember-cli-preprocess-registry/preprocessors.js:25:10)
    at Object.module.exports.setupRegistry (/Users/cthoburn/Github/data/node_modules/ember-cli-preprocess-registry/preprocessors.js:46:3)
    at Class.init (/Users/cthoburn/Github/data/node_modules/ember-cli/lib/models/addon.js:328:7)
    at Class.superWrapper [as init] (/Users/cthoburn/Github/data/node_modules/core-object/lib/assign-properties.js:34:20)
    at Class.init (/Users/cthoburn/Github/data/packages/-build-infra/src/addon-build-config-for-data-package.js:21:44)
    at Class.superWrapper [as init] (/Users/cthoburn/Github/data/node_modules/core-object/lib/assign-properties.js:34:20)
@mixonic
Copy link
Member

mixonic commented Aug 30, 2019

Perhaps _findHtmlbarsPreprocessor is returning undefined?

The _addon property here is supposed to come from https://github.com/ember-cli/ember-cli-htmlbars/blob/d31e851ee02d35c035cd81cc6ef5f1571fd81fc2/ember-addon-main.js#L43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants