Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate updating deprecation-workflow.js #66

Open
elwayman02 opened this issue Oct 3, 2019 · 2 comments
Open

Automate updating deprecation-workflow.js #66

elwayman02 opened this issue Oct 3, 2019 · 2 comments

Comments

@elwayman02
Copy link
Contributor

Is it possible to automate what this addon provides even further? For example, we could write test output to a log, run flushDeprecations() against that log, and then diff against the existing deprecation-workflow.js to add newly discovered deprecations.

This could be a huge improvement to utilize as part of an upgrade workflow. After running ember-cli-update, you just trigger a script in this addon that automatically updates its own config based on deprecations triggered by your project's tests.

@rwjblue
Copy link
Member

rwjblue commented Oct 4, 2019

Ya, we definitely can do something like this (would require a bit of work, but seems worth it).

@jelhan
Copy link

jelhan commented Nov 14, 2022

I also feel that manually maintaining config/deprecation-workflow.js makes it difficult to keep the file up-to-date. It would be great if we could replace all manual steps to upgrade it by a command. Something like ember deprecation-workflow update, which runs the tests, collects a list of triggered deprecation and writes it to config/deprecation-workflow.js. This would also allow us to add a ember deprecation-workflow check command, which verifies that all deprecation are listed in config/deprecation-workflow. This would be helpful to verify in CI that the file is up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants