Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember-test-helpers-codemod fails with errors for nonexisting acceptance tests #124

Open
rajasegar opened this issue Jan 28, 2020 · 2 comments
Open

ember-test-helpers-codemod fails with errors for nonexisting acceptance tests #124

rajasegar opened this issue Jan 28, 2020 · 2 comments

Comments

@rajasegar
Copy link
Contributor

ember-test-helpers-codemod acceptance tests/acceptance fails in addons
Most addons might not have acceptance tests so there will not be any folder named acceptance tests.
@kellyselden
Copy link
Member

How should we fix this? Is this something they need to fix? Is their README wrong?

@rajasegar
Copy link
Contributor Author

I don't think we can fix this. One thing we can think about is removing the second command from the manifest only on the assumption that there won't be any acceptance tests. But that is too not the right solution. And there is nothing wrong with their README also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellyselden @rajasegar