Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing options to iterate command #84

Open
christiancueto opened this issue Apr 14, 2017 · 6 comments
Open

passing options to iterate command #84

christiancueto opened this issue Apr 14, 2017 · 6 comments

Comments

@christiancueto
Copy link

Just a quick question, I used to be able to run the following:

ember exam:iterate 3 --options '---split 24 --parallel --random' but since upgrading to v0.6.2 I get the following error:

The option '--split 24 --parallel --random' is not registered with the exam:iterate command. Run `ember exam:iterate --help` for a list of supported options.

I just wanted to know if this was updated & what would be the correct way to pass these options to the iterate command.

Any help would be greatly appreciated.

@trentmwillis
Copy link
Member

Nothing changed within ember-exam itself that would cause that to happen. Is it an actual error or just a warning? Meaning, does the command still run correctly even after the message?

I suspect this is due to a change in the however Ember-CLI parses arguments.

@christiancueto
Copy link
Author

christiancueto commented Apr 14, 2017

@trentmwillis The command does not run correctly from what I am seeing. When I try and run the command provided in the description, it does not partition the tests on each iteration.

@trentmwillis
Copy link
Member

Okay, I'll try to take a look at it this weekend and see if I can figure out what happened.

@rwjblue
Copy link
Member

rwjblue commented Apr 27, 2017

We determined that a bump of nopt caused the change, and are reverting to the older version.

I do want to suggest changing the way this works though 😛 . Instead of --options as a string that contains options I'd suggest something similar to what ember-try does to allow the exact command to be specified (but obviously choose a sensible default):

ember exam:iterate 3 -- ember exam --split 24 --parallel --random

@trentmwillis
Copy link
Member

Okay, so this was a bug upstream. That said, I agree with the change @rwjblue has suggested here.

@rwjblue
Copy link
Member

rwjblue commented May 1, 2017

FYI - The upstream bug should have been fixed with ember-cli > 2.12.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants